FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-109408: Remove Ubuntu unit tests from Azure Pipelines by hugovk · Pull Request #109452 · python/cpython · GitHub

/ cpython Public

gh-109408: Remove Ubuntu unit tests from Azure Pipelines - #109452

Merged
hugovk merged 4 commits into
python:mainfrom
hugovk:ap-rm-ubuntu-tests
Sep 17, 2023
ConversationCommits (4)ChecksFiles changed
Merged

gh-109408: Remove Ubuntu unit tests from Azure Pipelines#109452
hugovk merged 4 commits into
python:mainfrom
hugovk:ap-rm-ubuntu-tests

Conversation

hugovk commented Sep 15, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Both ci.yml and pr.yml run Ubuntu_CI_Tests which runs .azure-pipelines/posix-steps.yml

.azure-pipelines/posix-steps.yml does:

  1. checkout/setup
  2. build Python
  3. display build info
  4. run unit tests
  5. run patchcheck (PR only)
  6. report unit test results

This PR removes the Ubuntu unit test run (4)/report (6), as we're running it on GitHub Actions.

Because patchcheck is only run for PRs (pr.yml), there's no point building Python and then doing nothing for ci.yml, so we can remove the whole Ubuntu_CI_Tests from ci.yml.

Finally, rename Ubuntu_CI_Tests to something more accurate: Ubuntu_Patchcheck.

This speeds up Ubunutu part of pr.yml from ~14 to ~4 mins, and ci.yml from ~14 to 0 mins.

bedevere-app Bot mentioned this pull request Sep 15, 2023
Closed
hugovk added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 15, 2023
sobolevn mentioned this pull request Sep 15, 2023
Closed
itamaro approved these changes Sep 17, 2023
View reviewed changes

itamaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LG!

hugovk merged commit a75daed into python:main Sep 17, 2023
hugovk deleted the ap-rm-ubuntu-tests branch September 17, 2023 17:46

miss-islington commented Sep 17, 2023

Copy link
Copy Markdown
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington commented Sep 17, 2023

Copy link
Copy Markdown
Contributor

Sorry, @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a75daed7e004ee9a53b160307c4c072656176a02 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2023
pythongh-109408: Remove Ubuntu unit tests from Azure Pipelines (pytho…
4f7e1bb 
…nGH-109452)

(cherry picked from commit a75daed)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

bedevere-app Bot commented Sep 17, 2023

Copy link
Copy Markdown

GH-109519 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 17, 2023

bedevere-app Bot commented Sep 17, 2023

Copy link
Copy Markdown

GH-109520 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Sep 17, 2023
hugovk added a commit to hugovk/cpython that referenced this pull request Sep 17, 2023
[3.11] pythongh-109408: Remove Ubuntu unit tests from Azure Pipelines (…
28cceb8 
…pythonGH-109452)

(cherry picked from commit a75daed)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Sep 17, 2023
[3.11] gh-109408: Remove Ubuntu unit tests from Azure Pipelines (GH-1…
e15b663 
…09452) (#109520)

(cherry picked from commit a75daed)
Yhg1s pushed a commit that referenced this pull request Sep 17, 2023
[3.12] gh-109408: Remove Ubuntu unit tests from Azure Pipelines (GH-1…
5c439fb 
…09452) (#109519)

gh-109408: Remove Ubuntu unit tests from Azure Pipelines (GH-109452)
(cherry picked from commit a75daed)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
pythongh-109408: Remove Ubuntu unit tests from Azure Pipelines (pytho…
be22f09 
…n#109452)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

itamaro itamaro approved these changes

Assignees

hugovk

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL