gh-109466: Add ipv6_mapped property to IPv4Address - #109467
Merged
gpshead merged 10 commits intoNov 5, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@asvetlov I think you were a more recent committer here. Any chance for a review? Thanks! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Friendly ping @asvetlov. Thanks. |
Sorry, something went wrong.
hugovk
reviewed
Nov 5, 2023
hugovk
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I'll let someone else review whether this is needed, but here's some docs suggestions.
Sorry, something went wrong.
Comment thread
Doc/library/ipaddress.rst
Outdated
Comment thread
Lib/ipaddress.py
Outdated
Comment thread
Lib/ipaddress.py
Outdated
Comment thread
Misc/NEWS.d/next/Library/2023-09-15-12-30-21.gh-issue-109466.6ah-aw.rst
Outdated
Comment thread
Doc/whatsnew/3.13.rst
Outdated
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
…ah-aw.rst Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
gpshead
approved these changes
Nov 5, 2023
gpshead
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
thanks!
Sorry, something went wrong.
gpshead
enabled auto-merge (squash)
November 5, 2023 16:23
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Adds the `IPv4Address.ipv6_mapped` property. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
|
Cross-referencing #119814 for visibility. |
Sorry, something went wrong.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Adds the `IPv4Address.ipv6_mapped` property. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated docs and added a corresponding unit test.
Fixes #109466.
📚 Documentation preview 📚: https://cpython-previews--109467.org.readthedocs.build/