[3.12] gh-109125: Run mypy on Tools/wasm (GH-109126) - #109561
Closed
hugovk wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
(cherry picked from commit f65497f) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
This was referenced Sep 19, 2023
corona10
reviewed
Sep 19, 2023
Comment thread
.github/workflows/mypy.yml
Outdated
corona10
reviewed
Sep 19, 2023
Comment thread
.github/workflows/mypy.yml
Outdated
hugovk
marked this pull request as draft
September 19, 2023 07:16
Copy link
Copy Markdown
Member
Author
|
I've updated the PR only to backport the Tools/wasm checking, but on second thoughts, let's close this and we can add it later if anyone wants it. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit f65497f)
Includes the other missing ones.