gh-108724: Fix _PySemaphore compile error on WASM - #109583
Merged
ericsnowcurrently merged 1 commit intoSep 19, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Some WASM platforms have POSIX semaphores, but not sem_timedwait.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit a9c0a5b 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
ericsnowcurrently
approved these changes
Sep 19, 2023
ericsnowcurrently
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
The build step succeeded for "buildbot/wasm32-emscripten node (dynamic linking) PR", so I'm calling this good. :) |
Sorry, something went wrong.
ericsnowcurrently
enabled auto-merge (squash)
September 19, 2023 17:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some WASM platforms have POSIX semaphores, but not sem_timedwait.