[3.11] gh-108388: Convert test_concurrent_futures to package (#108401) - #109704
Merged
vstinner merged 2 commits intoSep 22, 2023
Merged
[3.11] gh-108388: Convert test_concurrent_futures to package (#108401)#109704vstinner merged 2 commits into
vstinner merged 2 commits into
Conversation
* AsCompletedTests: Revert test_future_times_out() => test_zero_timeout()
* Restore TODO comment
* ThreadPoolExecutorTest.test_hang_global_shutdown_lock():
add @support.requires_resource('cpu').
Copy link
Copy Markdown
Member
Author
|
Backporting PR #108401 to 3.11 branch was challenging. I used git cherry-pick -x, fixed conflicts, and then I "undone" manually the change by moving code again into as single Lib/test/test_concurrent_futures.py to compare changes, and I compared code before/after using meld. I found a few minor differences, the second commit of this PR:
I also compared the new test_concurrent_futures/ directory in 3.11 and main branches. There are only minor differences. Some minor changes no backported to 3.11. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Once this change is merged, I will be able to backport #109703 to 3.11. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.