Repository navigation
[3.12] gh-106584: Fix exit code for unittest in Python 3.12 (GH-106588) - #109725
Merged
Yhg1s merged 1 commit intoOct 2, 2023
Merged
Yhg1s merged 1 commit into
Yhg1s merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This was referenced Sep 22, 2023
Copy link
Copy Markdown
Contributor
|
This is a bug in 3.12.0, the fix should land for 3.12.1. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
@miss-islington, @ambv I suspect this change is breaking green on skipped tests: CleanCut/green#277 Green is tracking test duration by setting a time when startTest is called then calculates the duration in stopTest, unfortunately the changes here are now skipping startTest but not stopTest, if I read the changes correctly. I will work with the green maintainer to update green to be compatible. There is no issue if no tests are skipped. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 8fc0713)
Co-authored-by: EliseevEgor egor.eliseev@jetbrains.com
Co-authored-by: sunmy2019 59365878+sunmy2019@users.noreply.github.com
Co-authored-by: Nikita Sobolev mail@sobolevn.me