FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-109653: Just import `recursive_repr` in `dataclasses` by sobolevn · Pull Request #109822 · python/cpython · GitHub

/ cpython Public

gh-109653: Just import recursive_repr in dataclasses #109822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericvsmith merged 1 commit into from
Mar 5, 2024
+3 −23
Conversation 11 Commits 1 Checks 0 Files changed 1
Merged

gh-109653: Just import recursive_repr in dataclasses #109822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
26 changes: 3 additions & 23 deletions Lib/dataclasses.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@
import types
import inspect
import keyword
import functools
import itertools
import abc
import _thread
from reprlib import recursive_repr
from types import FunctionType, GenericAlias


Expand Down Expand Up @@ -245,25 +244,6 @@ def __repr__(self):
property,
})

# This function's logic is copied from "recursive_repr" function in
# reprlib module to avoid dependency.
def _recursive_repr(user_function):
# Decorator to make a repr function return "..." for a recursive
# call.
repr_running = set()

@functools.wraps(user_function)
def wrapper(self):
key = id(self), _thread.get_ident()
if key in repr_running:
return '...'
repr_running.add(key)
try:
result = user_function(self)
finally:
repr_running.discard(key)
return result
return wrapper

class InitVar:
__slots__ = ('type', )
Expand Down Expand Up @@ -322,7 +302,7 @@ def __init__(self, default, default_factory, init, repr, hash, compare,
self.kw_only = kw_only
self._field_type = None

@_recursive_repr
@recursive_repr()
def __repr__(self):
return ('Field('
f'name={self.name!r},'
Expand Down Expand Up @@ -632,7 +612,7 @@ def _repr_fn(fields, globals):
for f in fields]) +
')"'],
globals=globals)
return _recursive_repr(fn)
return recursive_repr()(fn)


def _frozen_get_del_attr(cls, fields, globals):
Expand Down
Back | FazBrowse Home | New Git URL