gh-109832: concurrent.futures test_deadlock restores sys.stderr - #109887
Merged
vstinner merged 1 commit intoSep 26, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
test_error_at_task_unpickle() and test_error_during_result_unpickle_in_result_handler() now restore sys.stderr which is overriden by _raise_error_ignore_stderr().
vstinner
force-pushed
the
cf_restore_stderr
branch
from
9a687c0 to
236ac3d
Compare
September 26, 2023 08:02
Copy link
Copy Markdown
Member
Author
|
Windows x64 failed: ERROR: test_CTRL_BREAK_EVENT (test.test_os.Win32KillTests.test_CTRL_BREAK_EVENT)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\a\cpython\cpython\Lib\test\test_os.py", line 2616, in test_CTRL_BREAK_EVENT
self._kill_with_event(signal.CTRL_BREAK_EVENT, "CTRL_BREAK_EVENT")
File "D:\a\cpython\cpython\Lib\test\test_os.py", line 2591, in _kill_with_event
os.kill(proc.pid, signal.SIGINT)
PermissionError: [WinError 5] Access is denied
Test passed when re-run: test_CTRL_BREAK_EVENT (test.test_os.Win32KillTests.test_CTRL_BREAK_EVENT) ... ok |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
I created issue gh-109888 for this failure. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 26, 2023
…pythonGH-109887) test_error_at_task_unpickle() and test_error_during_result_unpickle_in_result_handler() now restore sys.stderr which is overriden by _raise_error_ignore_stderr(). (cherry picked from commit 2897142) Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Copy Markdown
|
GH-109892 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 26, 2023
…pythonGH-109887) test_error_at_task_unpickle() and test_error_during_result_unpickle_in_result_handler() now restore sys.stderr which is overriden by _raise_error_ignore_stderr(). (cherry picked from commit 2897142) Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Copy Markdown
|
GH-109893 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
vstinner
added a commit
that referenced
this pull request
Sep 26, 2023
GH-109887) (#109893) gh-109832: concurrent.futures test_deadlock restores sys.stderr (GH-109887) test_error_at_task_unpickle() and test_error_during_result_unpickle_in_result_handler() now restore sys.stderr which is overriden by _raise_error_ignore_stderr(). (cherry picked from commit 2897142) Co-authored-by: Victor Stinner <vstinner@python.org>
csm10495
pushed a commit
to csm10495/cpython
that referenced
this pull request
Sep 28, 2023
…python#109887) test_error_at_task_unpickle() and test_error_during_result_unpickle_in_result_handler() now restore sys.stderr which is overriden by _raise_error_ignore_stderr().
Yhg1s
pushed a commit
that referenced
this pull request
Oct 2, 2023
GH-109887) (#109892) gh-109832: concurrent.futures test_deadlock restores sys.stderr (GH-109887) test_error_at_task_unpickle() and test_error_during_result_unpickle_in_result_handler() now restore sys.stderr which is overriden by _raise_error_ignore_stderr(). (cherry picked from commit 2897142) Co-authored-by: Victor Stinner <vstinner@python.org>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…python#109887) test_error_at_task_unpickle() and test_error_during_result_unpickle_in_result_handler() now restore sys.stderr which is overriden by _raise_error_ignore_stderr().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_error_at_task_unpickle() and
test_error_during_result_unpickle_in_result_handler() now restore sys.stderr which is overriden by _raise_error_ignore_stderr().