FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-109408: Stop running patchcheck in CI by AA-Turner · Pull Request #109895 · python/cpython · GitHub

/ cpython Public

gh-109408: Stop running patchcheck in CI - #109895

Merged
AA-Turner merged 1 commit into
python:mainfrom
AA-Turner:patchcheck/delete-azure-pipelines
Aug 3, 2024
Merged

gh-109408: Stop running patchcheck in CI#109895
AA-Turner merged 1 commit into
python:mainfrom
AA-Turner:patchcheck/delete-azure-pipelines

Conversation

AA-Turner commented Sep 26, 2023
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Comment thread Tools/patchcheck/patchcheck.py Outdated
Comment thread Tools/patchcheck/patchcheck.py Outdated
AA-Turner force-pushed the patchcheck/delete-azure-pipelines branch from d707f5c to 269bebe Compare July 26, 2024 22:30
AA-Turner marked this pull request as ready for review July 26, 2024 23:04

Copy link
Copy Markdown
Member Author

If I understand Éric's comments correctly, they don't block this PR itself, but more speak to improving the experience of running CPython's linting tools. In an effort to unblock this PR, I have opened #122333 as a sketch proposal.

A

merwok commented Jul 27, 2024

Copy link
Copy Markdown
Member

I’m not active enough for my comments to have weight here. But you could have a discussion in the core-dev discuss forum to check agreement and avoid people being surprised after the fact.

Copy link
Copy Markdown
Member Author

But you could have a discussion in the core-dev discuss forum to check agreement and avoid people being surprised after the fact.

We did last year (https://discuss.python.org/t/34743), which I don't think raised any opposition to removing the (now duplicative) whitespace checks in CI. The wider patchcheck tool will remain, and #122333 will hopefully give us a unified 'local static checks' target. If/when that's merged, I think telling people on Discourse as a reminder would be useful.

A

hugovk changed the title GH-109408: Stop running patchcheck in CI gh-109408: Stop running patchcheck in CI Jul 27, 2024

Copy link
Copy Markdown
Member Author

It's been a week or so with no comment (and a year since the PR was opened), so I'll go ahead and merge this. If things go wrong we can always revert.

A

AA-Turner merged commit cc6839a into python:main Aug 3, 2024
AA-Turner deleted the patchcheck/delete-azure-pipelines branch August 3, 2024 11:52
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL