FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.11] gh-102304: doc: Add links to Stable ABI and Limited C API (#105345) (#105371) by AA-Turner · Pull Request #109901 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.11] gh-102304: doc: Add links to Stable ABI and Limited C API (#105345) (#105371) - #109901

Merged
erlend-aasland merged 2 commits into
python:3.11from
AA-Turner:backport-82ab13c-3.11
Sep 29, 2023
ConversationCommits (2)ChecksFiles changed
Merged

[3.11] gh-102304: doc: Add links to Stable ABI and Limited C API (#105345) (#105371)#109901
erlend-aasland merged 2 commits into
python:3.11from
AA-Turner:backport-82ab13c-3.11

Conversation

AA-Turner commented Sep 26, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

(cherry picked from commit bae415a)

(cherry picked from commit 0202aa0) (cherry picked from commit 82ab13c)

These targets were added for 3.13 and 3.12, but they're needed for the devguide: python/devguide#1167

A

📚 Documentation preview 📚: https://cpython-previews--109901.org.readthedocs.build/

AA-Turner requested a review from a team as a code owner September 26, 2023 12:53
This was referenced Sep 26, 2023
Closed
Merged
[3.11] pythongh-102304: doc: Add links to Stable ABI and Limited C API (
e4154d4 
python#105345) (python#105371)

* pythongh-102304: doc: Add links to Stable ABI and Limited C API (python#105345)

* Add "limited-c-api" and "stable-api" references.
* Rename "stable-abi-list" reference to "limited-api-list".
* Makefile: Document files regenerated by "make regen-limited-abi"
* Remove first empty line in generated files:

  - Lib/test/test_stable_abi_ctypes.py
  - PC/python3dll.c

(cherry picked from commit bae415a)

* pythongh-102304: Fix up Simple ABI doc (pythonGH-105351)

(cherry picked from commit 0202aa0)
(cherry picked from commit 82ab13c)
AA-Turner force-pushed the backport-82ab13c-3.11 branch from 967be20 to e4154d4 Compare September 26, 2023 12:54

erlend-aasland commented Sep 26, 2023

Copy link
Copy Markdown
Contributor

Unfortunately, bae415a does a lot of things:

  • doc updates
  • C source updates
  • script updates

AFAICS, only the doc updates are relevant for python/devguide#1167? @vstinner, should the whole commit be backported, or only parts of it?

vstinner commented Sep 26, 2023

Copy link
Copy Markdown
Member

It's up to you, I don't know. I understood that the doc should look the same in all branches: all doc changes should be backported.

AA-Turner commented Sep 26, 2023

Copy link
Copy Markdown
Member Author

should the whole commit be backported, or only parts of it?

I'd intended to only backport the documentation changes; something went wrong in preparing this PR. But if we want to backport everything happy to update the PR, I just wanted to err on the cautious side.

A

erlend-aasland commented Sep 26, 2023

Copy link
Copy Markdown
Contributor

It's up to you, I don't know. I understood that the doc should look the same in all branches: all doc changes should be backported.

The problem is that the original commit is not a doc change; it changes a lot of non-doc stuff.

erlend-aasland reviewed Sep 26, 2023
View reviewed changes
Comment thread Doc/c-api/stable.rst

erlend-aasland commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

@AA-Turner, could you write comment that sums up this change (for the merge commit message)?

AA-Turner commented Sep 29, 2023

Copy link
Copy Markdown
Member Author

First draft:

Add links to the Stable ABI and Limited C API

  • Add "limited-c-api" and "stable-api" targets
  • Rename the "stable-abi-list" target to "limited-api-list"

A

vstinner approved these changes Sep 29, 2023
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

erlend-aasland commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

First draft:

Looks ok to me!

erlend-aasland merged commit d81bcc2 into python:3.11 Sep 29, 2023
AA-Turner deleted the backport-82ab13c-3.11 branch January 13, 2024 20:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
erlend-aasland erlend-aasland approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL