gh-110050: Adjust the newline position in the TypeError message of the random.seed call. - #110051
Merged
ambv merged 4 commits intoOct 10, 2023
Merged
gh-110050: Adjust the newline position in the TypeError message of the random.seed call.#110051ambv merged 4 commits into
ambv merged 4 commits into
Conversation
…ssage of the random.seed call.
Copy link
Copy Markdown
Contributor
|
The newline was intentional. Without it, the error line is 90 characters which is too long: >>> len('TypeError: The only supported seed types are: None, int, float, str, bytes, and bytearray.')
90
That said, it might be nice to move the newline to just before the None giving a more natural line break. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Ah OK, this is a strange convention to me, since in many cases you can't control the length of the message when it also includes strings formatted from other variables. Also, the file names in the trackeback are usually already much longer. That said, I updated this PR to just adjust the newline position. Thanks for the review! |
Sorry, something went wrong.
rhettinger
approved these changes
Sep 29, 2023
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2023
… of the random.seed call. (pythonGH-110051) (cherry picked from commit ce43d5f) Co-authored-by: Yilei Yang <hi@mangoumbrella.com> Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-110625 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
… of the random.seed call. (python#110051) Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.