FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101100: Fix sphinx warnings in `library/difflib.rst` by sobolevn · Pull Request #110074 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-101100: Fix sphinx warnings in library/difflib.rst - #110074

Merged
hugovk merged 1 commit into
python:mainfrom
sobolevn:issue-101100-difflib
Sep 29, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-101100: Fix sphinx warnings in library/difflib.rst#110074
hugovk merged 1 commit into
python:mainfrom
sobolevn:issue-101100-difflib

Conversation

sobolevn commented Sep 29, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Before:

/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:571: WARNING: py:meth reference target not found: quick_ratio
/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:571: WARNING: py:meth reference target not found: real_quick_ratio
/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:571: WARNING: py:meth reference target not found: ratio
/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:596: WARNING: py:meth reference target not found: ratio
/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:596: WARNING: py:meth reference target not found: ratio
/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:603: WARNING: py:meth reference target not found: get_matching_blocks
/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:612: WARNING: py:meth reference target not found: get_matching_blocks
/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:616: WARNING: py:meth reference target not found: get_opcodes
/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:690: WARNING: py:meth reference target not found: io.BaseIO.readlines

📚 Documentation preview 📚: https://cpython-previews--110074.org.readthedocs.build/

sobolevn requested a review from hugovk September 29, 2023 06:35
bedevere-app Bot mentioned this pull request Sep 29, 2023
Closed
hugovk added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 29, 2023
hugovk approved these changes Sep 29, 2023
View reviewed changes
Comment thread Doc/library/difflib.rst
Note that the last tuple returned by :meth:`get_matching_blocks` is always a
dummy, ``(len(a), len(b), 0)``, and this is the only case in which the last
Note that the last tuple returned by :meth:`~SequenceMatcher.get_matching_blocks`
is always a dummy, ``(len(a), len(b), 0)``, and this is the only case in which the last

hugovk Sep 29, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

For next time, let's avoid rewrapping when making changes. It's okay to extend the line length for edits and it's much easier to review with a smaller diff. Thanks!

hugovk merged commit d102d39 into python:main Sep 29, 2023

miss-islington commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d102d39bbe175f179f28e4d4bea99dc122da5f8e 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2023
pythongh-101100: Fix sphinx warnings in library/difflib.rst (python…
2a4ad34 
…GH-110074)

(cherry picked from commit d102d39)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-app Bot commented Sep 29, 2023

Copy link
Copy Markdown

GH-110081 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 29, 2023
hugovk pushed a commit to hugovk/cpython that referenced this pull request Sep 29, 2023
pythongh-101100: Fix sphinx warnings in library/difflib.rst (python…
221446b 
…#110074)

(cherry picked from commit d102d39)
hugovk added a commit to hugovk/cpython that referenced this pull request Sep 29, 2023
[3.11] pythongh-101100: Fix sphinx warnings in library/difflib.rst (p…
608c75a 
…ythonGH-110074).

(cherry picked from commit d102d39)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-app Bot commented Sep 29, 2023

Copy link
Copy Markdown

GH-110082 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Sep 29, 2023
hugovk pushed a commit to hugovk/cpython that referenced this pull request Sep 29, 2023
[3.11] pythongh-101100: Fix sphinx warnings in library/difflib.rst (p…
c84b833 
…ythonGH-110074).

(cherry picked from commit d102d39)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
hugovk added a commit that referenced this pull request Sep 29, 2023
[3.11] gh-101100: Fix sphinx warnings in library/difflib.rst (GH-11…
6bc722d 
…0074) (#110082)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Yhg1s pushed a commit that referenced this pull request Sep 29, 2023
[3.12] gh-101100: Fix sphinx warnings in library/difflib.rst (GH-11…
297104c 
…0074) (#110081)

gh-101100: Fix sphinx warnings in `library/difflib.rst` (GH-110074)
(cherry picked from commit d102d39)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-101100: Fix sphinx warnings in library/difflib.rst (python…
366408f 
…#110074)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes

Assignees

hugovk

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL