FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Docs: Add the time to the HTML last updated format by AA-Turner · Pull Request #110091 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Docs: Add the time to the HTML last updated format - #110091

Merged
vstinner merged 7 commits into
python:mainfrom
AA-Turner:docs/last-updated-time
Nov 15, 2023
ConversationCommits (7)ChecksFiles changed
Merged

Docs: Add the time to the HTML last updated format#110091
vstinner merged 7 commits into
python:mainfrom
AA-Turner:docs/last-updated-time

Conversation

AA-Turner commented Sep 29, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

AA-Turner added docs Documentation in the Doc dir skip issue skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 29, 2023
AA-Turner requested a review from hugovk September 29, 2023 10:29
AA-Turner mentioned this pull request Sep 29, 2023
Closed
vstinner approved these changes Sep 29, 2023
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thank you for today that.

... Do you have access to the timezone?

vstinner commented Sep 29, 2023

Copy link
Copy Markdown
Member

If you have no timezone information, can we use UTC timestamp?

vstinner commented Sep 29, 2023

Copy link
Copy Markdown
Member

Is it UTC?

https://github.com/sphinx-doc/sphinx/blob/b9c85984d2f4863e4c09932c746d915e3233507b/sphinx/util/i18n.py#L192-L199

vstinner reviewed Sep 29, 2023
View reviewed changes
Comment thread Doc/conf.py Outdated
Add the timezone
8559481 
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner approved these changes Sep 29, 2023
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, even better with the timezone :-)

hugovk commented Sep 29, 2023

Copy link
Copy Markdown
Member

👍

hugovk requested changes Sep 29, 2023
View reviewed changes
Comment thread Doc/conf.py Outdated
vstinner reviewed Sep 29, 2023
View reviewed changes
Comment thread Doc/conf.py Outdated
hugovk reviewed Sep 30, 2023
View reviewed changes
Comment thread Doc/conf.py Outdated

AA-Turner commented Oct 18, 2023

Copy link
Copy Markdown
Member Author

Now:

A

AA-Turner requested a review from hugovk October 18, 2023 09:42
hugovk approved these changes Oct 18, 2023
View reviewed changes

hugovk left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good:

Non-blocking:

I'd still prefer "UTC" instead of "GMT", strictly speaking they're not the same: GMT is a timezone used by some countries, UTC is the standard. And UTC is maybe better known, judging by Google results (GMT: "About 527 000 000 results", UTC: "About 2 550 000 000 results").

vstinner approved these changes Oct 18, 2023
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

vstinner commented Oct 18, 2023

Copy link
Copy Markdown
Member

Ah right, UTC is better. time.gmtime() is documented to return time in UTC timezone: https://docs.python.org/dev/library/time.html#time.gmtime

vstinner reviewed Nov 15, 2023
View reviewed changes
Comment thread Doc/conf.py Outdated
vstinner enabled auto-merge (squash) November 15, 2023 03:56
vstinner merged commit 6c214de into python:main Nov 15, 2023

miss-islington-app Bot commented Nov 15, 2023

Copy link
Copy Markdown

Thanks @AA-Turner for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 15, 2023
Docs: Add the time to the HTML last updated format (pythonGH-110091)
58589b8 
(cherry picked from commit 6c214de)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

bedevere-app Bot commented Nov 15, 2023

Copy link
Copy Markdown

GH-112102 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 15, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 15, 2023
Docs: Add the time to the HTML last updated format (pythonGH-110091)
5a65d25 
(cherry picked from commit 6c214de)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

bedevere-app Bot commented Nov 15, 2023

Copy link
Copy Markdown

GH-112103 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Nov 15, 2023
vstinner pushed a commit that referenced this pull request Nov 15, 2023
[3.12] Docs: Add the time to the HTML last updated format (GH-110091) (…
c190552 
…#112102)

Docs: Add the time to the HTML last updated format (GH-110091)
(cherry picked from commit 6c214de)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
vstinner pushed a commit that referenced this pull request Nov 15, 2023
[3.11] Docs: Add the time to the HTML last updated format (GH-110091) (…
a92b9e5 
…#112103)

Docs: Add the time to the HTML last updated format (GH-110091)
(cherry picked from commit 6c214de)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

vstinner commented Nov 15, 2023

Copy link
Copy Markdown
Member

I need this feature. I never understand if https://docs.python.org/dev/ was updated or not. So I merged the PR.

Thanks @AA-Turner for this nice enhancement!

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Docs: Add the time to the HTML last updated format (python#110091)
4d2f252
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Docs: Add the time to the HTML last updated format (python#110091)
90fc443
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
hugovk hugovk approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL