Repository navigation
GH-101100: Fix reference warnings for __enter__ and __exit__ - #110112
Merged
hugovk merged 3 commits intoOct 19, 2023
Merged
hugovk merged 3 commits into
hugovk merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ezio-melotti
approved these changes
Sep 30, 2023
ezio-melotti
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The changes look ok, but see #110118 (review)
Sorry, something went wrong.
hugovk
approved these changes
Oct 18, 2023
hugovk
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Re: #110118 (comment), I think we're good to merge.
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 19, 2023
…t__`` (pythonGH-110112) (cherry picked from commit 63acf78) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 19, 2023
…t__`` (pythonGH-110112) (cherry picked from commit 63acf78) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-111075 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-111076 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--110112.org.readthedocs.build/