FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-110300: Fix Refleaks in test_interpreters and test__xxinterpchannels by ericsnowcurrently · Pull Request #110318 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-110300: Fix Refleaks in test_interpreters and test__xxinterpchannels #110318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 7 commits into from
Oct 4, 2023
Conversation 2 Commits 7 Checks 0 Files changed
Merged

gh-110300: Fix Refleaks in test_interpreters and test__xxinterpchannels #110318

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fbbebfd
Add a missing decref.
ericsnowcurrently Oct 3, 2023
8bfdf89
Add more missing decrefs.
ericsnowcurrently Oct 3, 2023
47a2bf6
Decref after get_module_from_owned_type().
ericsnowcurrently Oct 3, 2023
b291931
Stop leaking file descriptors.
ericsnowcurrently Oct 3, 2023
009aa91
Merge branch 'main' into fix-refleaks
ericsnowcurrently Oct 3, 2023
bb7e4e0
Temporarily drop the _register_end_types() call.
ericsnowcurrently Oct 3, 2023
2462033
Temporarily skip a failing test.
ericsnowcurrently Oct 4, 2023
File filter

Filter by extension

Filter by extension .c  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
Prev Previous commit
Next Next commit
Add more missing decrefs.
  • Loading branch information
ericsnowcurrently committed Oct 3, 2023
commit 8bfdf89e44ceaa9f7b43846e5d241efdab18c5c3
5 changes: 4 additions & 1 deletion Modules/_xxinterpchannelsmodule.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2013,6 +2013,7 @@ _channel_end_from_xid(_PyCrossInterpreterData *data)
}
PyTypeObject *cls = _get_current_channel_end_type(cid->end);
if (cls == NULL) {
Py_DECREF(cid);
return NULL;
}
PyObject *obj = PyObject_CallOneArg((PyObject *)cls, (PyObject *)cid);
Expand All @@ -2028,7 +2029,9 @@ _channel_end_shared(PyThreadState *tstate, PyObject *obj,
if (cidobj == NULL) {
return -1;
}
if (_channelid_shared(tstate, cidobj, data) < 0) {
int res = _channelid_shared(tstate, cidobj, data);
Py_DECREF(cidobj);
if (res < 0) {
return -1;
}
data->new_object = _channel_end_from_xid;
Expand Down
Back | FazBrowse Home | New Git URL