FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

DOC: Reuse old bltin-boolean-values ref tag by pllim · Pull Request #110371 · python/cpython · GitHub

/ cpython Public

DOC: Reuse old bltin-boolean-values ref tag - #110371

Merged
hauntsaninja merged 4 commits into
python:mainfrom
pllim:patch-1
Oct 4, 2023
ConversationCommits (4)ChecksFiles changed
Merged

DOC: Reuse old bltin-boolean-values ref tag#110371
hauntsaninja merged 4 commits into
python:mainfrom
pllim:patch-1

Conversation

pllim commented Oct 4, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

gh-103487: Reuse old bltin-boolean-values ref tag to avoid breaking downstream intersphinx via numpydoc

The PR is opened as suggested in https://github.com/python/cpython/pull/103487/files#r1346336728 by @hauntsaninja

close astropy/astropy#15428

close numpy/numpydoc#509

📚 Documentation preview 📚: https://cpython-previews--110371.org.readthedocs.build/

DOC: Reuse old bltin-boolean-values ref tag
558f91a 
to avoid breaking downstream intersphinx via numpydoc
bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 4, 2023
This was referenced Oct 4, 2023
Closed
Merged
AlexWaygood reviewed Oct 4, 2023
View reviewed changes
Comment thread Doc/library/stdtypes.rst
pllim and others added 2 commits October 4, 2023 15:36
Por que no los dos
f5d5aa6 
[ci skip]

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Revert changes to functions.rst
c855c70

pllim commented Oct 4, 2023

Copy link
Copy Markdown
Contributor Author

p.s. If you don't want to use the "Squash and merge" button, please let me know so I can clone the repo properly and squash it by hand.

hauntsaninja added the needs backport to 3.12 only security fixes label Oct 4, 2023

AlexWaygood commented Oct 4, 2023

Copy link
Copy Markdown
Member

p.s. If you don't want to use the "Squash and merge" button, please let me know so I can clone the repo properly and squash it by hand.

We always use "squash and merge" at CPython, no worries :)

hauntsaninja merged commit f786029 into python:main Oct 4, 2023

miss-islington commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

Thanks @pllim for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

hauntsaninja commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

Thank you!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2023
Add back bltin-boolean-values ref tag (pythonGH-110371)
e87de28 
To avoid breaking downstream intersphinx via numpydoc
(cherry picked from commit f786029)

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

bedevere-app Bot commented Oct 4, 2023

Copy link
Copy Markdown

GH-110372 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 4, 2023
pllim deleted the patch-1 branch October 4, 2023 19:58

pllim commented Oct 4, 2023

Copy link
Copy Markdown
Contributor Author

Thank you for the quick reviews and resolution!

hauntsaninja pushed a commit that referenced this pull request Oct 4, 2023
[3.12] Add back bltin-boolean-values ref tag (GH-110371) (#110372)
36a7d6b 
Add back bltin-boolean-values ref tag (GH-110371)

To avoid breaking downstream intersphinx via numpydoc
(cherry picked from commit f786029)

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

pllim commented Oct 5, 2023

Copy link
Copy Markdown
Contributor Author

By the way, how soon will https://docs.python.org/3/ point to the updated doc with this patch? 👀

AlexWaygood commented Oct 5, 2023

Copy link
Copy Markdown
Member

By the way, how soon will https://docs.python.org/3/ point to the updated doc with this patch? 👀

I think the docs are rebuilt once a day!

pllim mentioned this pull request Oct 5, 2023
Merged
1 task
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Add back bltin-boolean-values ref tag (python#110371)
3b430a9 
To avoid breaking downstream intersphinx via numpydoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood left review comments
hauntsaninja Awaiting requested review from hauntsaninja

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WARNING: undefined label: 'python:bltin-boolean-values' RTD fails with WARNING: undefined label: 'python:bltin-boolean-values'

5 participants

Back | FazBrowse Home | New Git URL