FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-110631: Fix reST indentation in `Doc/library` by ezio-melotti · Pull Request #110685 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-110631: Fix reST indentation in Doc/library - #110685

Merged
ezio-melotti merged 1 commit into
python:mainfrom
ezio-melotti:fix-ind-library
Oct 11, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-110631: Fix reST indentation in Doc/library#110685
ezio-melotti merged 1 commit into
python:mainfrom
ezio-melotti:fix-ind-library

Conversation

ezio-melotti commented Oct 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

This PR fixes indentation errors that resulted in spurious blockquotes and definition lists in the Doc/library dir.

📚 Documentation preview 📚: https://cpython-previews--110685.org.readthedocs.build/

ezio-melotti added docs Documentation in the Doc dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 11, 2023
ezio-melotti self-assigned this Oct 11, 2023
bedevere-app Bot mentioned this pull request Oct 11, 2023
Closed
ezio-melotti commented Oct 11, 2023
View reviewed changes
Comment thread Doc/library/tkinter.ttk.rst
Comment on lines 1001 to 1002
the widget is resized.
* width: width
width: width
The width of the column in pixels.

ezio-melotti Oct 11, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This and the next few chunks created a weird definition list with bullets. I removed the bullets to create a regular definition list. The markup of the dts could be improved by adding some ``...`` too, to make them stand out more.

erlend-aasland commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

Sphinx indents should be three, not two spaces, no?

ezio-melotti commented Oct 11, 2023

Copy link
Copy Markdown
Member Author

Sphinx indents should be three, not two spaces, no?

I just time-machined an answer for you here: #110635 (comment)

erlend-aasland changed the title gh-110631: fix wrong indentation in the Doc/library dir. gh-110631: Fix reST indentation in the Doc/library dir Oct 11, 2023
erlend-aasland reviewed Oct 11, 2023
View reviewed changes
Comment thread Doc/library/sqlite3.rst
ezio-melotti changed the title gh-110631: Fix reST indentation in the Doc/library dir gh-110631: Fix reST indentation in Doc/library Oct 11, 2023
ezio-melotti merged commit bb7923f into python:main Oct 11, 2023

miss-islington commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

Thanks @ezio-melotti for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

Sorry, @ezio-melotti, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bb7923f556537a463c403dc1097726d8a8e1a6f2 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2023
pythongh-110631: Fix reST indentation in Doc/library (pythonGH-110685)
f7b74df 
Fix wrong indentation in the Doc/library dir.
(cherry picked from commit bb7923f)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

bedevere-app Bot commented Oct 11, 2023

Copy link
Copy Markdown

GH-110736 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 11, 2023
ezio-melotti added a commit to ezio-melotti/cpython that referenced this pull request Oct 11, 2023
[3.11] pythongh-110631: Fix reST indentation in Doc/library (python…
809a677 
…GH-110685)

Fix wrong indentation in the Doc/library dir..
(cherry picked from commit bb7923f)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

bedevere-app Bot commented Oct 11, 2023

Copy link
Copy Markdown

GH-110737 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Oct 11, 2023
ezio-melotti added a commit that referenced this pull request Oct 11, 2023
[3.12] gh-110631: Fix reST indentation in Doc/library (GH-110685) (#…
cae968b 
…110736)

gh-110631: Fix reST indentation in `Doc/library` (GH-110685)

Fix wrong indentation in the Doc/library dir.
(cherry picked from commit bb7923f)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
ezio-melotti added a commit that referenced this pull request Oct 11, 2023
[3.11] gh-110631: Fix reST indentation in Doc/library (GH-110685) (#…
07471cd 
…110737)

* [3.11] gh-110631: Fix reST indentation in `Doc/library` (GH-110685)

Fix wrong indentation in the Doc/library dir..
(cherry picked from commit bb7923f)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

* Fix merge glitch.
ezio-melotti deleted the fix-ind-library branch October 11, 2023 21:11
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-110631: Fix reST indentation in Doc/library (python#110685)
03e0aa6 
Fix wrong indentation in the Doc/library dir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes
hugovk hugovk approved these changes
pradyunsg Awaiting requested review from pradyunsg
AlexWaygood Awaiting requested review from AlexWaygood
ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner
rhettinger Awaiting requested review from rhettinger rhettinger is a code owner
berkerpeksag Awaiting requested review from berkerpeksag
vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees

ezio-melotti

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL