FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-110721: Use the traceback module for PyErr_Display() and fallback to the C implementation by pablogsal · Pull Request #110702 · python/cpython · GitHub

/ cpython Public

gh-110721: Use the traceback module for PyErr_Display() and fallback to the C implementation - #110702

Merged
pablogsal merged 13 commits into
python:mainfrom
pablogsal:traceback
Oct 12, 2023
ConversationCommits (13)ChecksFiles changed
Merged

gh-110721: Use the traceback module for PyErr_Display() and fallback to the C implementation#110702
pablogsal merged 13 commits into
python:mainfrom
pablogsal:traceback

Conversation

pablogsal commented Oct 11, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

pablogsal requested review from ambv and lysnikolaou October 11, 2023 11:22

iritkatriel commented Oct 11, 2023

Copy link
Copy Markdown
Member

If no tests are failing then the fallback is not tested.

pablogsal commented Oct 11, 2023

Copy link
Copy Markdown
Member Author

If no tests are failing then the fallback is not tested.

Yup, currently working on adapting the tests. Sorry, I forgot to mark it as a draft.

pablogsal marked this pull request as draft October 11, 2023 12:11
pablogsal marked this pull request as ready for review October 11, 2023 14:46
pablogsal changed the title Use the traceback module for PyErr_Display() and fallback to the C implementation gh-110721: Use the traceback module for PyErr_Display() and fallback to the C implementation Oct 11, 2023
bedevere-app Bot mentioned this pull request Oct 11, 2023
Closed
iritkatriel approved these changes Oct 11, 2023
View reviewed changes
Comment thread Lib/test/test_traceback.py Outdated
Comment thread Lib/traceback.py Outdated
iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Oct 11, 2023

bedevere-bot commented Oct 11, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit c812a3c 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Oct 11, 2023
pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 11, 2023

bedevere-bot commented Oct 11, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit d55b7e7 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 11, 2023
iritkatriel reviewed Oct 12, 2023
View reviewed changes
Comment thread Lib/test/test_sys.py
pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 12, 2023

bedevere-bot commented Oct 12, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 4d438ec 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 12, 2023
iritkatriel reviewed Oct 12, 2023
View reviewed changes
Comment thread Python/pythonrun.c Outdated
Comment thread Python/pythonrun.c Outdated
Comment thread Python/pythonrun.c Outdated
Comment thread Python/pythonrun.c Outdated
Comment thread Python/pythonrun.c Outdated
Comment thread Python/pythonrun.c Outdated
pablogsal enabled auto-merge (squash) October 12, 2023 14:22
pablogsal merged commit e733136 into python:main Oct 12, 2023
pablogsal deleted the traceback branch October 12, 2023 14:52
This was referenced Nov 9, 2023
Open
Closed
perrinjerome mentioned this pull request Jan 17, 2024
Closed
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-110721: Use the traceback module for PyErr_Display() and fal…
0330b2a 
…lback to the C implementation (python#110702)
nineteendo mentioned this pull request Dec 3, 2024
Closed
nineteendo mentioned this pull request Dec 11, 2024
Merged
gpshead mentioned this pull request Feb 11, 2025
Merged
tideofwords mentioned this pull request Aug 26, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

iritkatriel iritkatriel approved these changes
lysnikolaou Awaiting requested review from lysnikolaou
ambv Awaiting requested review from ambv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL