FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-85283: _stat extension now uses the limited C API by vstinner · Pull Request #110711 · python/cpython · GitHub

/ cpython Public

gh-85283: _stat extension now uses the limited C API - #110711

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:limited_stat
Oct 11, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-85283: _stat extension now uses the limited C API#110711
vstinner merged 1 commit into
python:mainfrom
vstinner:limited_stat

Conversation

vstinner commented Oct 11, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

The _stat C extension is now built with the limited C API.

📚 Documentation preview 📚: https://cpython-previews--110711.org.readthedocs.build/

bedevere-app Bot mentioned this pull request Oct 11, 2023
Closed

vstinner commented Oct 11, 2023

Copy link
Copy Markdown
Member Author

vstinner commented Oct 11, 2023

Copy link
Copy Markdown
Member Author

cc @erlend-aasland @corona10 @encukou

gpshead commented Oct 11, 2023

Copy link
Copy Markdown
Member

I approved as this seems trivial so "lets do it!", obviously figuring out the windows build excitement in CI needs to happen first.

vstinner commented Oct 11, 2023

Copy link
Copy Markdown
Member Author

What's going on? Now Windows build fails with:

LINK : fatal error LNK1104: cannot open file 'python313_d.lib' [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

vstinner commented Oct 11, 2023

Copy link
Copy Markdown
Member Author

LINK : fatal error LNK1104: cannot open file 'python313_d.lib' [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

Ok, I found the root issue and wrote a fix: PR gh-110725. The problem comes from PyAPI_FUNC(), PyAPI_DATA() and PyMODINIT_FUNC macros which have a different implementation depending if the 3 Py_BUILD_CORE macros are defined or not.

merwok changed the title gh-85283: _stat extension uses the limited C API gh-85283: _stat extension now uses the limited C API Oct 11, 2023
pythongh-85283: _stat extension uses the limited C API
a0cc4f5 
The _stat C extension is now built with the limited C API.
vstinner merged commit 88ecb19 into python:main Oct 11, 2023
vstinner deleted the limited_stat branch October 11, 2023 22:06

vstinner commented Oct 12, 2023

Copy link
Copy Markdown
Member Author

Merged, thanks for the review @gpshead and @erlend-aasland.

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-85283: _stat extension now uses the limited C API (python#11…
022ef91 
…0711)

pythongh-85283: _stat extension uses the limited C API

The _stat C extension is now built with the limited C API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes
erlend-aasland erlend-aasland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL