FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-110774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase by graingert · Pull Request #110776 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-110774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase - #110776

Merged
gvanrossum merged 6 commits into
python:mainfrom
graingert:unittest-loop-factory
Oct 31, 2023
ConversationCommits (6)ChecksFiles changed
Merged

gh-110774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase#110776
gvanrossum merged 6 commits into
python:mainfrom
graingert:unittest-loop-factory

Conversation

graingert commented Oct 12, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

graingert changed the title allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase gh-10774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase Oct 12, 2023
graingert changed the title gh-10774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase gh-110774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase Oct 12, 2023
bedevere-app Bot mentioned this pull request Oct 12, 2023
Closed
graingert commented Oct 12, 2023
View reviewed changes
Comment thread Doc/library/unittest.rst Outdated
graingert commented Oct 12, 2023
View reviewed changes
Comment thread Doc/library/unittest.rst
graingert commented Oct 12, 2023
View reviewed changes
Comment thread Doc/library/unittest.rst
graingert commented Oct 12, 2023
View reviewed changes
Comment thread Doc/library/unittest.rst Outdated
graingert commented Oct 12, 2023
View reviewed changes
Comment thread Lib/test/test_unittest/test_async_case.py Outdated
graingert force-pushed the unittest-loop-factory branch from 47669b3 to 0fbb894 Compare October 12, 2023 15:20
graingert marked this pull request as ready for review October 12, 2023 15:32
willingc approved these changes Oct 13, 2023
View reviewed changes

willingc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @graingert. This looks good to me.

gvanrossum approved these changes Oct 31, 2023
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yup, thanks!

gvanrossum merged commit 7705306 into python:main Oct 31, 2023
graingert deleted the unittest-loop-factory branch October 31, 2023 22:32
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
pythongh-110774: allow setting the Runner(loop_factory=...) from Isol…
3512380 
…atedAsyncioTestCase (python#110776)


Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-110774: allow setting the Runner(loop_factory=...) from Isol…
73dc956 
…atedAsyncioTestCase (python#110776)


Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-110774: allow setting the Runner(loop_factory=...) from Isol…
47d7b80 
…atedAsyncioTestCase (python#110776)


Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

willingc willingc approved these changes
gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL