FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101100: Fix sphinx warnings in `library/asyncio-dev.rst` by sobolevn · Pull Request #111179 · python/cpython · GitHub

Repository navigation

gh-101100: Fix sphinx warnings in library/asyncio-dev.rst - #111179

Merged
willingc merged 3 commits into
python:mainfrom
sobolevn:issue-101100-asyncio-dev
Oct 22, 2023
Merged

willingc merged 3 commits into
python:mainfrom
sobolevn:issue-101100-asyncio-dev

Conversation

sobolevn commented Oct 22, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Please, note that this change is not about asyncio-eventloop.rst, but is about asyncio-dev.rst which just happens to reference asyncio-eventloop.rst:

/Users/sobolev/Desktop/cpython/Doc/library/asyncio-dev.rst:60: WARNING: py:attr reference target not found: loop.slow_callback_duration

I've also fixed one asyncio-eventloop.rst problem, which cannot be detected by Sphinx (just because I saw it):

I've moved the .. versionchanged inside the function body.

In the next PR I will fix warnings specific to asyncio-eventloop.rst.


📚 Documentation preview 📚: https://cpython-previews--111179.org.readthedocs.build/

willingc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @sobolevn for the PR. I've added a small clarification to the attribute definition.

Comment thread Doc/library/asyncio-eventloop.rst Outdated
Comment thread Doc/library/asyncio-eventloop.rst Outdated
willingc enabled auto-merge (squash) October 22, 2023 17:05
willingc merged commit 8c689c9 into python:main Oct 22, 2023

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2023
…thonGH-111179)

* pythongh-101100: Fix sphinx warnings in `library/asyncio-dev.rst`

* Update Doc/library/asyncio-eventloop.rst

* Update Doc/library/asyncio-eventloop.rst

---------

(cherry picked from commit 8c689c9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2023
…thonGH-111179)

* pythongh-101100: Fix sphinx warnings in `library/asyncio-dev.rst`

* Update Doc/library/asyncio-eventloop.rst

* Update Doc/library/asyncio-eventloop.rst

---------

(cherry picked from commit 8c689c9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>

bedevere-app Bot commented Oct 22, 2023

Copy link
Copy Markdown

GH-111185 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 22, 2023

bedevere-app Bot commented Oct 22, 2023

Copy link
Copy Markdown

GH-111186 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Oct 22, 2023
willingc added a commit that referenced this pull request Oct 22, 2023
…H-111179) (#111185)

gh-101100: Fix sphinx warnings in `library/asyncio-dev.rst` (GH-111179)

* gh-101100: Fix sphinx warnings in `library/asyncio-dev.rst`

* Update Doc/library/asyncio-eventloop.rst

* Update Doc/library/asyncio-eventloop.rst

---------

(cherry picked from commit 8c689c9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
willingc added a commit that referenced this pull request Oct 22, 2023
…H-111179) (#111186)

gh-101100: Fix sphinx warnings in `library/asyncio-dev.rst` (GH-111179)

* gh-101100: Fix sphinx warnings in `library/asyncio-dev.rst`

* Update Doc/library/asyncio-eventloop.rst

* Update Doc/library/asyncio-eventloop.rst

---------

(cherry picked from commit 8c689c9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…thonGH-111179)

* pythongh-101100: Fix sphinx warnings in `library/asyncio-dev.rst`

* Update Doc/library/asyncio-eventloop.rst

* Update Doc/library/asyncio-eventloop.rst

---------

Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…thonGH-111179)

* pythongh-101100: Fix sphinx warnings in `library/asyncio-dev.rst`

* Update Doc/library/asyncio-eventloop.rst

* Update Doc/library/asyncio-eventloop.rst

---------

Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL