FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-111181: Fix enum doctests by sobolevn · Pull Request #111180 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-111181: Fix enum doctests - #111180

Merged
ethanfurman merged 5 commits into
python:mainfrom
sobolevn:fix-enum-doctests
Oct 30, 2023
ConversationCommits (5)ChecksFiles changed
Merged

gh-111181: Fix enum doctests#111180
ethanfurman merged 5 commits into
python:mainfrom
sobolevn:fix-enum-doctests

Conversation

sobolevn commented Oct 22, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Working on a full description of what is going on.

#111181

📚 Documentation preview 📚: https://cpython-previews--111180.org.readthedocs.build/

sobolevn mentioned this pull request Oct 22, 2023
Closed
sobolevn changed the title Fix enum doctests gh-111181: Fix enum doctests Oct 22, 2023

sobolevn commented Oct 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

@ethanfurman as I said I am not sure that my fixes are correct, I just want to show you that there are some broken tests at the moment. I need your help with the details :)

serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 23, 2023

ethanfurman commented Oct 23, 2023

Copy link
Copy Markdown
Member

Thank you for getting the doc tests to always run. I'll work on getting the doc tests correct.

ethanfurman self-assigned this Oct 23, 2023
sobolevn marked this pull request as ready for review October 28, 2023 06:03
sobolevn requested a review from ethanfurman as a code owner October 28, 2023 06:03
ethanfurman merged commit c4dc5a6 into python:main Oct 30, 2023

miss-islington-app Bot commented Oct 30, 2023

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington-app Bot commented Oct 30, 2023

Copy link
Copy Markdown

Sorry, @sobolevn and @ethanfurman, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c4dc5a6ae8aa13abb743182df088f1a3526d1bcd 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 30, 2023
pythongh-111181: Fix enum doctests (pythonGH-111180)
a3ee1bc 
(cherry picked from commit c4dc5a6)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>

bedevere-app Bot commented Oct 30, 2023

Copy link
Copy Markdown

GH-111518 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 30, 2023
ethanfurman added a commit that referenced this pull request Oct 31, 2023
[3.12] gh-111181: Fix enum doctests (GH-111180) (GH-111518)
ec00397 
gh-111181: Fix enum doctests (GH-111180)
(cherry picked from commit c4dc5a6)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ethanfurman added a commit to ethanfurman/cpython that referenced this pull request Nov 1, 2023
pythongh-111181: Fix enum doctests (pythonGH-111180)
db862fc 
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
(cherry picked from commit c4dc5a6)

bedevere-app Bot commented Nov 1, 2023

Copy link
Copy Markdown

GH-111617 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Nov 1, 2023
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
pythongh-111181: Fix enum doctests (pythonGH-111180)
248d504 
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
sobolevn mentioned this pull request Nov 3, 2023
Open
ethanfurman added a commit that referenced this pull request Nov 3, 2023
[3.11] gh-111181: Fix enum doctests (GH-111180) (GH-111617)
4a61169 
gh-111181: Fix enum doctests (GH-111180)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
(cherry picked from commit c4dc5a6)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
ethanfurman mentioned this pull request Dec 20, 2023
Closed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-111181: Fix enum doctests (pythonGH-111180)
97228d9 
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-111181: Fix enum doctests (pythonGH-111180)
3303674 
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
ethanfurman ethanfurman approved these changes

Assignees

ethanfurman

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL