FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-94438: Add additional cases to mark_stacks with tests by savannahostrowski · Pull Request #111237 · python/cpython · GitHub

/ cpython Public

gh-94438: Add additional cases to mark_stacks with tests - #111237

Merged
brandtbucher merged 8 commits into
python:mainfrom
savannahostrowski:jump_if_none
Oct 24, 2023
ConversationCommits (8)ChecksFiles changed
Merged

gh-94438: Add additional cases to mark_stacks with tests#111237
brandtbucher merged 8 commits into
python:mainfrom
savannahostrowski:jump_if_none

Conversation

savannahostrowski commented Oct 23, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

After reading through #94438, it appeared that there were still outstanding issues with mark_stacks as there was no case that checking for POP_JUMP_IF_NONE and POP_JUMP_IF_NOT_NONE, which could break pdb's jump in 3.11 or higher. This adds these case to the switch statement plus a couple of tests.

ghost commented Oct 23, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot mentioned this pull request Oct 23, 2023
Closed
3 tasks

bedevere-app Bot commented Oct 23, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

savannahostrowski commented Oct 23, 2023

Copy link
Copy Markdown
Member Author

cc: @brandtbucher

brandtbucher self-assigned this Oct 23, 2023
brandtbucher self-requested a review October 23, 2023 22:00
brandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 23, 2023

brandtbucher commented Oct 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

(Note to self that the 3.11 backport will probably need to be manual.)

bedevere-app Bot commented Oct 23, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

brandtbucher requested changes Oct 23, 2023
View reviewed changes

brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks a ton for this! This is some really tricky code.

Just a couple of comments on the tests:

Comment thread Lib/test/test_sys_settrace.py Outdated
Comment thread Misc/NEWS.d/next/Core and Builtins/2023-10-23-22-11-09.gh-issue-94438.y2pITu.rst Outdated
Comment thread Lib/test/test_sys_settrace.py Outdated

bedevere-app Bot commented Oct 23, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

brandtbucher reviewed Oct 23, 2023
View reviewed changes
Comment thread Lib/test/test_sys_settrace.py Outdated
brandtbucher reviewed Oct 23, 2023
View reviewed changes
Comment thread Lib/test/test_sys_settrace.py Outdated
Update Lib/test/test_sys_settrace.py
0143197 
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

brandtbucher commented Oct 24, 2023

Copy link
Copy Markdown
Member

Sorry, one last thing... can you add yourself to Misc/ACKS? :)

brandtbucher merged commit 6640f1d into python:main Oct 24, 2023

miss-islington-app Bot commented Oct 24, 2023

Copy link
Copy Markdown

Thanks @savannahostrowski for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington-app Bot commented Oct 24, 2023

Copy link
Copy Markdown

Sorry, @savannahostrowski and @brandtbucher, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6640f1d8d2462ca0877e1d2789e1721767e9caf2 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2023
pythonGH-94438: Restore ability to jump over None tests (pythonGH-111237
2c77dfb 
)

(cherry picked from commit 6640f1d)

Co-authored-by: Savannah Ostrowski <sostrowski@microsoft.com>

bedevere-app Bot commented Oct 24, 2023

Copy link
Copy Markdown

GH-111243 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 24, 2023

willingc commented Oct 24, 2023

Copy link
Copy Markdown
Contributor

Congrats @savannahostrowski for the successful contribution. 🎉

@brandtbucher 😄

savannahostrowski mentioned this pull request Oct 25, 2023
Merged

bedevere-app Bot commented Oct 25, 2023

Copy link
Copy Markdown

GH-111338 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Oct 25, 2023
gaogaotiantian mentioned this pull request Oct 26, 2023
Merged
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythonGH-94438: Restore ability to jump over None tests (pythonGH-111237
d9715b6 
)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythonGH-94438: Restore ability to jump over None tests (pythonGH-111237
a721258 
)
savannahostrowski deleted the jump_if_none branch September 27, 2024 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brandtbucher brandtbucher approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL