Repository navigation
GH-79033: docs: Minor improvement to asyncio.Server.wait_closed() - #111260
Closed
Dreamsorcerer wants to merge 1 commit into
Closed
Dreamsorcerer wants to merge 1 commit into
Dreamsorcerer wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Dreamsorcerer
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
October 24, 2023 12:56
gvanrossum
approved these changes
Oct 24, 2023
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This phrasing is fine, and we should merge it.
Note, however, that there's another chapter to the wait_closed litany:
#79033 (comment)
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gvanrossum Just a small followup from #98582.
In aiohttp, for some reason it was originally written as calling wait_closed() before cancelling the open connections. So, from that wording in the Python documentation I always assumed that it was waiting for the sockets to stop listening, rather than waiting for the connections to be closed. Clearly this was wrong, and it actually did nothing, and aiohttp's shutdown should have been broken long ago.
In particular, the close() method says 'The sockets that represent existing incoming client connections are left open.'.
So, saying that it waits for close() to complete, which itself says connections are left open was a little confusing.
📚 Documentation preview 📚: https://cpython-previews--111260.org.readthedocs.build/