| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add a new C-API function PyDict_Pop to replace a previously removed underscore function. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| Expand Up | @@ -2272,6 +2272,16 @@ _PyDict_Pop(PyObject *dict, PyObject *key, PyObject *deflt) | |
| return _PyDict_Pop_KnownHash(dict, key, hash, deflt); | ||
| } | ||
|
|
||
| PyObject * | ||
| PyDict_Pop(PyObject *dict, PyObject *key, PyObject *deflt) | ||
| { | ||
| if (!PyDict_Check(dict)) { | ||
| PyErr_BadInternalCall(); | ||
| return -1; | ||
|
Comment thread
Copy link
Copy Markdown
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityShould certainly be return NULL?
Sorry, something went wrong.
All reactions
|
||
| } | ||
| return _PyDict_Pop(dict, key, deflt); | ||
| } | ||
|
|
||
| /* Internal version of dict.from_keys(). It is subclass-friendly. */ | ||
| PyObject * | ||
| _PyDict_FromKeys(PyObject *cls, PyObject *iterable, PyObject *value) | ||
| Expand Down | ||
| Back | FazBrowse Home | New Git URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityI would prefer to return -1 on error, 0 if the key doesn't exist, 1 if the key exists.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityHow would the caller know the popped value then?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.