gh-111374: Add a new PYTHON_FROZEN_MODULES env var, equivalent of -X frozen_modules. - #111411
Merged
gpshead merged 13 commits intoNov 1, 2023
Merged
gh-111374: Add a new PYTHON_FROZEN_MODULES env var, equivalent of -X frozen_modules.#111411gpshead merged 13 commits into
gpshead merged 13 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
gpshead
reviewed
Oct 28, 2023
Comment thread
Doc/using/cmdline.rst
Outdated
Copy link
Copy Markdown
Member
|
Please also add this to https://docs.python.org/3.13/whatsnew/3.13.html |
Sorry, something went wrong.
hugovk
reviewed
Oct 29, 2023
hugovk
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for the docs changes. Looks good, just some little nits.
Sorry, something went wrong.
Comment thread
Doc/whatsnew/3.13.rst
Outdated
Comment thread
Misc/NEWS.d/next/Core and Builtins/2023-10-27-11-22-09.gh-issue-111374.e9lrPZ.rst
Outdated
Comment thread
Doc/using/cmdline.rst
Outdated
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
…e-111374.e9lrPZ.rst Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the review, -X frozen_modules is also updated. Please take another look. |
Sorry, something went wrong.
gpshead
approved these changes
Nov 1, 2023
gpshead
enabled auto-merge (squash)
November 1, 2023 20:12
FullteaR
pushed a commit
to FullteaR/cpython
that referenced
this pull request
Nov 3, 2023
…of `-X frozen_modules`. (python#111411) Adds a new PYTHON_FROZEN_MODULES env var to correspond with -X frozen_modules. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…of `-X frozen_modules`. (python#111411) Adds a new PYTHON_FROZEN_MODULES env var to correspond with -X frozen_modules. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…of `-X frozen_modules`. (python#111411) Adds a new PYTHON_FROZEN_MODULES env var to correspond with -X frozen_modules. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that config_get_env can't distinguish between "not set" and "set to an empty string"? So PYTHON_FROZEN_MODULES= means differently than -X frozen_modules without values. I'm not sure if this could create confusion, but on the other hand the use of -X frozen_modules or -X frozen_modules= with empty values isn't explicitly documented.
📚 Documentation preview 📚: https://cpython-previews--111411.org.readthedocs.build/