GH-111339: Move optimizer types to object.c - #111430
Merged
brandtbucher merged 5 commits intoOct 29, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
brandtbucher
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is solid, thanks. And great instinct with the renaming!
There's nothing wrong with this, just a few observations:
Sorry, something went wrong.
Comment thread
Objects/object.c
Outdated
Comment thread
Include/internal/pycore_optimizer.h
Outdated
Copy link
Copy Markdown
Member
|
(I think these types may need to be added to an ignore-list somewhere? I think the failing check has more info.) |
Sorry, something went wrong.
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
FullteaR
pushed a commit
to FullteaR/cpython
that referenced
this pull request
Nov 3, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves types defined in optimizer.c to static_types in object.c per @brandtbucher's hunch. I tried to abide by the naming conventions of the other types in static_types by updating names to be prefixed by _Py. Please let me know if this is incorrect.
I've tested this and I can no longer reproduce the assertion error.