FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-94808: Add coverage test for number check by ekohilas · Pull Request #111445 · python/cpython · GitHub

/ cpython Public

gh-94808: Add coverage test for number check - #111445

Merged
corona10 merged 5 commits into
python:mainfrom
ekohilas:gh-94808
Oct 29, 2023
ConversationCommits (5)ChecksFiles changed
Merged

gh-94808: Add coverage test for number check#111445
corona10 merged 5 commits into
python:mainfrom
ekohilas:gh-94808

Conversation

ekohilas commented Oct 29, 2023

Copy link
Copy Markdown
Contributor

Add coverage test for number check

gh-94808: Adds a coverage test for PyNumber_Check as part of #94808

Thanks to @corona10 for helping out!

ghost commented Oct 29, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot commented Oct 29, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

corona10 changed the title Add coverage test for number check gh-94808: Add coverage test for number check Oct 29, 2023
bedevere-app Bot mentioned this pull request Oct 29, 2023
Open
corona10 self-assigned this Oct 29, 2023
corona10 reviewed Oct 29, 2023
View reviewed changes
Comment thread Lib/test/test_capi/test_abstract.py Outdated
corona10 reviewed Oct 29, 2023
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would you like to extend the test to test float, and integer too?
And also for false tests for 'str' or something other types?
Looks like there is no explicit test for this API :)

ekohilas and others added 2 commits October 29, 2023 08:12
Update Lib/test/test_capi/test_abstract.py
9baf417 
Co-authored-by: Donghee Na <donghee.na92@gmail.com>
Update Lib/test/test_capi/test_abstract.py
445bcc0 
Co-authored-by: Donghee Na <donghee.na92@gmail.com>
corona10 reviewed Oct 29, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Tests/2023-10-29-05-41-47.gh-issue-94808.0FHZfr.rst Outdated
@@ -0,0 +1 @@
Add a C API test for the PyNumber_Check function.

corona10 Oct 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

And please remove this file too :)

Update Lib/test/test_capi/test_abstract.py
fd3d99c 
Co-authored-by: Donghee Na <donghee.na92@gmail.com>
ekohilas requested a review from corona10 October 29, 2023 06:33
corona10 approved these changes Oct 29, 2023
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm!

corona10 enabled auto-merge (squash) October 29, 2023 06:41
corona10 merged commit 842e5fc into python:main Oct 29, 2023
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Oct 29, 2023
pythongh-94808: Add coverage test for number check (pythongh-111445)
f2fc8ee
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
pythongh-94808: Add coverage test for number check (pythongh-111445)
55e150c
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-94808: Add coverage test for number check (pythongh-111445)
9a981fd
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-94808: Add coverage test for number check (pythongh-111445)
af287e6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 corona10 approved these changes

Assignees

corona10

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL