FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-111062: Separate linux build into a reusable workflow by NCLI · Pull Request #111446 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-111062: Separate linux build into a reusable workflow - #111446

Closed
NCLI wants to merge 19 commits into
python:mainfrom
NCLI:reusable_ubuntu_build
ConversationCommits (19)ChecksFiles changed
Closed

gh-111062: Separate linux build into a reusable workflow#111446
NCLI wants to merge 19 commits into
python:mainfrom
NCLI:reusable_ubuntu_build

Conversation

NCLI commented Oct 29, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot commented Oct 29, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app Bot mentioned this pull request Oct 29, 2023
Closed

This comment was marked as resolved.

Sign in to view
dimaqq reviewed Oct 29, 2023
View reviewed changes
Comment thread .github/workflows/reusable-build-ubuntu.yml Outdated
@@ -0,0 +1,84 @@
name: Tests

dimaqq Oct 29, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@corona10 says remove this name

dimaqq reviewed Oct 29, 2023
View reviewed changes
Comment thread .github/workflows/reusable-build-ubuntu.yml Outdated
contents: read

jobs:
name: 'Ubuntu reusable'

dimaqq Oct 29, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@corona10 says remove this name

NCLI changed the title GH-111062 Reusable ubuntu workflowfor build test GH-111062 Separate linux build into a reusable workflow Oct 29, 2023
dimaqq approved these changes Oct 29, 2023
View reviewed changes

dimaqq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks fine 😄

NCLI marked this pull request as ready for review October 29, 2023 07:00
NCLI requested a review from ezio-melotti as a code owner October 29, 2023 07:00
NCLI requested a review from hugovk as a code owner October 29, 2023 07:00
dimaqq mentioned this pull request Oct 29, 2023
Closed
hugovk changed the title GH-111062 Separate linux build into a reusable workflow gh-111062: Separate linux build into a reusable workflow Oct 29, 2023

hugovk commented Oct 29, 2023

Copy link
Copy Markdown
Member

Looking good, let's first decide on the name, re: #111062 (comment)

reusable-build-ubuntu.yml, or reusable-ubuntu.yml to match reusable-docs.yml?

corona10 commented Oct 30, 2023

Copy link
Copy Markdown
Member

Duplicated with #111452

corona10 closed this Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
hugovk Awaiting requested review from hugovk hugovk is a code owner
1 more reviewer
dimaqq dimaqq approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

hugovk

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL