gh-111246: Remove listening Unix socket on close by CendioOssman · Pull Request #111483 · python/cpython · GitHub

Relieve developers from the burden of manually cleaning up their Unix sockets by having asyncio take care of that internally.

Fixes #111246.

Issue: Listening asyncio UNIX socket isn't removed on close #111246

📚 Documentation preview 📚: https://cpython-previews--111483.org.readthedocs.build/

All commit authors signed the Contributor License Agreement.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Try to clean up the socket file we create so we don't add unused noise to the file system.

We only want to clean up *our* socket, so try to determine if we still own this address or if something else has replaced it.

Allow the implicit cleanup to be disabled in case there are some odd corner cases where this causes issues.

Once review has started (now) please don't force-push -- just add additional commits, otherwise review will be more work. We'll squash merge the final approved PR anyway. Also, merging main is usually not needed (GitHub is a bit pushy around that).

Ah, sorry. I'm used to the Linux kernel model where you churn the patch set until you have a history everyone is happy with. :)

I guess that means my careful splitting into distinct features wasn't necessary either. :)

FYI, the CLA is in progress via the slower organization route.

LG, two nits. Thanks for helping out!

Would you mind adding one-line comments to the new tests explaining what each test checks? They look so similar I first thought you had accidentally copied the test a few times. :-)

Sure. A commit with comments have been pushed.

Thanks!

@CendioOssman Could you sign the CLA please so we can merge?

It was signed last Tuesday, so it should hopefully be in someone's queue. I got a confirmation from Adobe at least.

It was signed last Tuesday, so it should hopefully be in someone's queue. I got a confirmation from Adobe at least.

Okay, I'll wait a bit for our side to update the database then.

@CendioOssman, in the case of corporate CLAs we still need you to click through the personal CLA signing route to mark your email as green. We don't use blanket email domain approvals.

Ah. The link said I should use the manual form "instead", so I never proceeded with the GitHub form.

I've clicked through the personal approval as well now.

Try to clean up the socket file we create so we don't add unused noise to the file system.

This is derived from python/cpython#111483 but available on all Python versions with uvloop, only that it's only enabled by default for Python 3.13 and above to be consistent with CPython behavior.

Try to clean up the socket file we create so we don't add unused noise to the file system.

This is derived from python/cpython#111483 but available on all Python versions with uvloop, only that it's only enabled by default for Python 3.13 and above to be consistent with CPython behavior. * Also add Python 3.13 to CI (#610) * Enable CI in debug mode * Fix CI to include [dev] --------- Co-authored-by: Fantix King <fantix.king@gmail.com>

CendioOssman requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners October 30, 2023 09:37

bedevere-app Bot mentioned this pull request Oct 27, 2023

Listening asyncio UNIX socket isn't removed on close #111246

Closed

bedevere-app Bot added the awaiting review label Oct 30, 2023

CendioOssman added 4 commits October 30, 2023 14:47

pythongh-111246 : Remove listening Unix socket on close (python#111246 )

21ff6be

Try to clean up the socket file we create so we don't add unused noise to the file system.

pythongh-111246 : Don't log on redundant socket cleanup (python#111246 )

21e9d8c

pythongh-111246 : Don't remove stolen Unix socket address (python#111246 )

df3b74e

We only want to clean up *our* socket, so try to determine if we still own this address or if something else has replaced it.

pythongh-111246 : Add opt-out of Unix socket cleanup (python#111246 )

93571fe

Allow the implicit cleanup to be disabled in case there are some odd corner cases where this causes issues.

CendioOssman force-pushed the unix_cleanup branch from 14a46a9 to 93571fe Compare October 30, 2023 13:47

gvanrossum reviewed Nov 1, 2023

View reviewed changes

kumaraditya303 reviewed Nov 2, 2023

View reviewed changes

Comment thread Doc/whatsnew/3.13.rst

CendioOssman added 2 commits November 6, 2023 16:36

Mention gh issue in whatsnew

acadacb

Add comments to new unix server cleanup tests

1db87b7

gvanrossum approved these changes Nov 6, 2023

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 6, 2023

gvanrossum merged commit 74b868f into python:main Nov 8, 2023

bedevere-app Bot removed the awaiting merge label Nov 8, 2023

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024

pythongh-111246 : Remove listening Unix socket on close (python#111483 )

2c03e74

Try to clean up the socket file we create so we don't add unused noise to the file system.

CendioOssman deleted the unix_cleanup branch February 28, 2024 10:51

fantix mentioned this pull request Aug 28, 2024

Add cleanup_socket param on create_unix_server() MagicStack/uvloop#623

Closed

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024

pythongh-111246 : Remove listening Unix socket on close (python#111483 )

6ed0fa2

Try to clean up the socket file we create so we don't add unused noise to the file system.

Hawk777 mentioned this pull request May 4, 2025

asyncio.start_unix_server maybe shouldn’t default to cleanup_socket=True when sock parameter is passed #133354

Open

+              class UnixServerCleanupTests(unittest.IsolatedAsyncioTestCase):
+                  @socket_helper.skip_unless_bind_unix_socket
+                  async def test_unix_server_addr_cleanup(self):

gh-111246: Remove listening Unix socket on close by CendioOssman · Pull Request #111483 · python/cpython · GitHub

Repository navigation

gh-111246: Remove listening Unix socket on close - #111483

gh-111246: Remove listening Unix socket on close#111483gvanrossum merged 6 commits intopython:mainpython/cpython:mainfrom CendioOssman:unix_cleanupCendioOssman/cpython:unix_cleanupCopy head branch name to clipboard

Conversation

CendioOssman commented Oct 30, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Oct 30, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-app Bot commented Oct 30, 2023

Uh oh!

gvanrossum commented Oct 30, 2023

Uh oh!

CendioOssman commented Oct 31, 2023

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gvanrossum Nov 1, 2023

Choose a reason for hiding this comment

Uh oh!

CendioOssman Nov 6, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

gvanrossum commented Nov 6, 2023

Uh oh!

CendioOssman commented Nov 7, 2023

Uh oh!

gvanrossum commented Nov 7, 2023

Uh oh!

ambv commented Nov 7, 2023

Uh oh!

CendioOssman commented Nov 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gh-111246: Remove listening Unix socket on close#111483
gvanrossum merged 6 commits into
python:mainfrom
CendioOssman:unix_cleanup

CendioOssman commented Oct 30, 2023 •
edited by github-actions Bot
Loading

ghost commented Oct 30, 2023 •
edited by ghost
Loading