gh-90815: Fix _PyMem_MimallocEnabled() compiler warning - #111522
Merged
vstinner merged 1 commit intoOct 30, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Don't declare _PyMem_MimallocEnabled() if WITH_PYMALLOC macro is not defined (./configure --without-pymalloc). Fix also a typo in _PyInterpreterState_FinalizeAllocatedBlocks().
Copy link
Copy Markdown
Member
Author
|
I tested that no warnings is emitted with these 4 configurations: pyconfigure_debug --with-pymalloc --with-mimalloc && make clean && make pyconfigure_debug --with-pymalloc --without-mimalloc && make clean && make pyconfigure_debug --without-pymalloc --with-mimalloc && make clean && make pyconfigure_debug --without-pymalloc --without-mimalloc && make clean && make with: $ alias pyconfigure_debug alias pyconfigure_debug='./configure --cache-file=../python-config.cache --with-pydebug CFLAGS=-O0 --with-system-expat' |
Sorry, something went wrong.
This was referenced Oct 30, 2023
FullteaR
pushed a commit
to FullteaR/cpython
that referenced
this pull request
Nov 3, 2023
…#111522) Don't declare _PyMem_MimallocEnabled() if WITH_PYMALLOC macro is not defined (./configure --without-pymalloc). Fix also a typo in _PyInterpreterState_FinalizeAllocatedBlocks().
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…#111522) Don't declare _PyMem_MimallocEnabled() if WITH_PYMALLOC macro is not defined (./configure --without-pymalloc). Fix also a typo in _PyInterpreterState_FinalizeAllocatedBlocks().
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…#111522) Don't declare _PyMem_MimallocEnabled() if WITH_PYMALLOC macro is not defined (./configure --without-pymalloc). Fix also a typo in _PyInterpreterState_FinalizeAllocatedBlocks().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't declare _PyMem_MimallocEnabled() if WITH_PYMALLOC macro is not defined (./configure --without-pymalloc).
Fix also a typo in _PyInterpreterState_FinalizeAllocatedBlocks().