gh-111495: Add tests for PyList C API by rawwar · Pull Request #111562 · python/cpython · GitHub

Adding tests for PyList C API - Issue #111495

Issue: Add more C API tests #111495

Signed-off-by: kalyanr <kalyan.ben10@live.com>

…o kalyan/test-capi-list Signed-off-by: kalyanr <kalyan.ben10@live.com>

…i-list Signed-off-by: kalyanr <kalyan.ben10@live.com>

@serhiy-storchaka , Is adding {NULL}, to test_methods[] necessary? yesterday, i was able to run make without any issues. Today, after taking the pull from main, its been failing. below are the details

static PyMethodDef test_methods[] = {
    {"list_check", list_check, METH_O},
    {"list_check_exact", list_check_exact, METH_O},
    {"list_new", list_new, METH_O},
    {"list_size", list_size, METH_O},
};

Fails with

(base) kalyan@rawwar:~/oss/python-projects/cpython$ make
gcc  -fno-strict-overflow -Wsign-compare -DNDEBUG -g -O3 -Wall    -std=c11 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -fvisibility=hidden  -I./Include/internal -I./Include/internal/mimalloc  -I. -I./Include    -fPIC -c ./Modules/_testcapi/list.c -o Modules/_testcapi/list.o
gcc -shared      Modules/_testcapimodule.o Modules/_testcapi/vectorcall.o Modules/_testcapi/vectorcall_limited.o Modules/_testcapi/heaptype.o Modules/_testcapi/abstract.o Modules/_testcapi/bytearray.o Modules/_testcapi/bytes.o Modules/_testcapi/unicode.o Modules/_testcapi/dict.o Modules/_testcapi/set.o Modules/_testcapi/list.o Modules/_testcapi/tuple.o Modules/_testcapi/getargs.o Modules/_testcapi/datetime.o Modules/_testcapi/docstring.o Modules/_testcapi/mem.o Modules/_testcapi/watchers.o Modules/_testcapi/long.o Modules/_testcapi/float.o Modules/_testcapi/complex.o Modules/_testcapi/numbers.o Modules/_testcapi/structmember.o Modules/_testcapi/exceptions.o Modules/_testcapi/code.o Modules/_testcapi/buffer.o Modules/_testcapi/pyatomic.o Modules/_testcapi/pyos.o Modules/_testcapi/file.o Modules/_testcapi/codec.o Modules/_testcapi/immortal.o Modules/_testcapi/heaptype_relative.o Modules/_testcapi/gc.o Modules/_testcapi/sys.o   -o Modules/_testcapi.cpython-313-x86_64-linux-gnu.so
[ERROR] Importing extension '_testcapi' failed!
Traceback (most recent call last):
  File "/home/kalyan/oss/python-projects/cpython/./Tools/build/check_extension_modules.py", line 412, in check_module_import
    bootstrap_load(spec)
  File "<frozen importlib._bootstrap>", line 960, in _load
  File "<frozen importlib._bootstrap>", line 915, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 813, in module_from_spec
  File "<frozen importlib._bootstrap_external>", line 1302, in create_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
ValueError: module functions cannot set METH_CLASS or METH_STATIC
Traceback (most recent call last):
  File "/home/kalyan/oss/python-projects/cpython/./Tools/build/check_extension_modules.py", line 483, in <module>
    main()
  File "/home/kalyan/oss/python-projects/cpython/./Tools/build/check_extension_modules.py", line 474, in main
    checker.check()
  File "/home/kalyan/oss/python-projects/cpython/./Tools/build/check_extension_modules.py", line 171, in check
    self.check_module_import(modinfo)
  File "/home/kalyan/oss/python-projects/cpython/./Tools/build/check_extension_modules.py", line 412, in check_module_import
    bootstrap_load(spec)
  File "<frozen importlib._bootstrap>", line 960, in _load
  File "<frozen importlib._bootstrap>", line 915, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 813, in module_from_spec
  File "<frozen importlib._bootstrap_external>", line 1302, in create_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
ValueError: module functions cannot set METH_CLASS or METH_STATIC
make: *** [Makefile:1177: checksharedmods] Error 1

But, when I include {NULL} like below, I am able to run make without any issues:

static PyMethodDef test_methods[] = {
    {"list_check", list_check, METH_O},
    {"list_check_exact", list_check_exact, METH_O},
    {"list_new", list_new, METH_O},
    {"list_size", list_size, METH_O},
    {NULL},
};

Signed-off-by: kalyanr <kalyan.ben10@live.com>

Oh! I wrote a very similar PR yesterday! I have a few more tests.

See also #111582. It would be nice if you with @vstinner unite your works.

Add tests for index equal to the size of the list, PY_SSIZE_T_MIN, PY_SSIZE_T_MAX (imported from _testcapi).

All functions that have Py_ssize_t parameter should be tested with the following values: 0, size-1, -1, size, PY_SSIZE_T_MIN, PY_SSIZE_T_MAX.

For methods like slice, they accept multiple Py_ssize_t parameters. Should each of these parameters be tested with the values you mentioned?

Signed-off-by: kalyanr <kalyan.ben10@live.com>

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

@vstinner , What can we do now? I'm not sure If I should continue working on this PR? Although, I also added tests for Py_LIMITED_API ones as well.
I am also planning on contributing tests for PyTuple. let me know if I can go ahead with that

Signed-off-by: kalyanr <kalyan.ben10@live.com>

Py_XNewRef() is wrong and causes a reference leak.

Thank you @rawwar.

I had too much minor suggestions, so I simply applied them myself.

Now it LGTM.

It only tests the wrapper, not the C API function.

I merged your PR @rawwar, thanks for adding tests for the PyList API!

Thanks @rawwar for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

(cherry picked from commit a3903c8) Co-authored-by: Kalyan <kalyan.ben10@live.com> Signed-off-by: kalyanr <kalyan.ben10@live.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>

GH-111861 is a backport of this pull request to the 3.12 branch.

(cherry picked from commit a3903c8) Signed-off-by: kalyanr <kalyan.ben10@live.com> Co-authored-by: Kalyan <kalyan.ben10@live.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>

Signed-off-by: kalyanr <kalyan.ben10@live.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>

rawwar added 2 commits October 31, 2023 21:37

init test c file

d43d9b2

single test added

119cd0e

bedevere-app Bot mentioned this pull request Oct 31, 2023

Add more C API tests #111495

Closed

10 tasks

rawwar added 5 commits October 31, 2023 22:43

fix lint

ccf1bff

fix list check tests

8d17ca6

lint

bd9415d

add 2 tests

17d60d1

add test

322eab9

Eclips4 requested a review from serhiy-storchaka October 31, 2023 19:15

rawwar added 5 commits November 1, 2023 02:06

add getitem test

5c58022

test list_get_item

6b12f1f

add test for setitem

70e385f

add test for setitem

3166ba4

Signed-off-by: kalyanr <kalyan.ben10@live.com>

Merge branch 'kalyan/test-capi-list' of github.com:rawwar/cpython int…

2a50fb8

…o kalyan/test-capi-list Signed-off-by: kalyanr <kalyan.ben10@live.com>

serhiy-storchaka reviewed Oct 31, 2023

View reviewed changes

Comment thread Lib/test/test_capi/test_list.py

Comment thread Lib/test/test_capi/test_list.py

Comment thread Lib/test/test_capi/test_list.py Outdated

Comment thread Modules/_testcapi/list.c Outdated

Comment thread Modules/_testcapi/list.c Outdated

Comment thread Lib/test/test_capi/test_list.py

skirpichev mentioned this pull request Nov 1, 2023

gh-111495: add stub files for C API test modules #111586

Merged

Merge branch 'main' of github.com:rawwar/cpython into kalyan/test-cap…

1c30f3b

…i-list Signed-off-by: kalyanr <kalyan.ben10@live.com>

serhiy-storchaka mentioned this pull request Nov 1, 2023

gh-111138: Test the public PyList C API #111582

Closed

rawwar added 2 commits November 1, 2023 14:28

add tests

392b3c6

Signed-off-by: kalyanr <kalyan.ben10@live.com>

lint fix

eac8c67

Signed-off-by: kalyanr <kalyan.ben10@live.com>

vstinner reviewed Nov 1, 2023

View reviewed changes

serhiy-storchaka reviewed Nov 1, 2023

View reviewed changes

rawwar and others added 5 commits November 1, 2023 15:36

add tests

0f40f6d

Signed-off-by: kalyanr <kalyan.ben10@live.com>

Update Lib/test/test_capi/test_list.py

40e4022

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Update Modules/_testcapi/list.c

d31fa57

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Update Lib/test/test_capi/test_list.py

433351d

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Update Lib/test/test_capi/test_list.py

34e915b

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

pr feedback fixes

0e340a1

Signed-off-by: kalyanr <kalyan.ben10@live.com>

bedevere-app Bot added the awaiting review label Nov 1, 2023

Update list.c

e486451

rawwar requested review from serhiy-storchaka and vstinner November 1, 2023 17:13

rawwar added 3 commits November 1, 2023 22:43

Merge branch 'main' into kalyan/test-capi-list

633951b

Merge branch 'main' into kalyan/test-capi-list

9afa50c

Merge branch 'main' into kalyan/test-capi-list

361b045

vstinner reviewed Nov 8, 2023

View reviewed changes

Comment thread Modules/_testcapi/list.c Outdated

Update Modules/_testcapi/list.c

ca07ac9

vstinner reviewed Nov 8, 2023

View reviewed changes

Comment thread Modules/_testcapi/list.c Outdated

vstinner and others added 3 commits November 8, 2023 15:57

Update Modules/_testcapi/list.c

dc039f1

Merge branch 'main' into kalyan/test-capi-list

5ecfa40

Minor fixes.

42a2a54

serhiy-storchaka approved these changes Nov 8, 2023

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 8, 2023

vstinner added the skip news label Nov 8, 2023

vstinner merged commit a3903c8 into python:main Nov 8, 2023

bedevere-app Bot removed the awaiting merge label Nov 8, 2023

serhiy-storchaka added the needs backport to 3.12 only security fixes label Nov 8, 2023

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 8, 2023

vstinner mentioned this pull request Nov 8, 2023

C API: Consider adding a public PyList_Extend() function #111138

Closed

+                      lst = [1, 2, NULL]
+                      self.assertEqual(getitem(lst, 0), 1)
+                      self.assertRaises(IndexError, getitem, lst, -1)
+                      self.assertRaises(IndexError, getitem, lst, 10)

+                  }
+                  NULLABLE(obj);
+                  NULLABLE(value);
+                  RETURN_INT(PyList_SetSlice(obj, ilow, ihigh, Py_XNewRef(value)));

		self.assertRaises(TypeError, setitem, lst, 1.5, 10)
		self.assertRaises(TypeError, setitem, 23, 'a', 5)

gh-111495: Add tests for PyList C API by rawwar · Pull Request #111562 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-111495: Add tests for PyList C API - #111562

gh-111495: Add tests for PyList C API#111562vstinner merged 33 commits intopython:mainpython/cpython:mainfrom rawwar:kalyan/test-capi-listrawwar/cpython:kalyan/test-capi-listCopy head branch name to clipboard

Conversation

rawwar commented Oct 31, 2023 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rawwar commented Nov 1, 2023

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka Nov 1, 2023

Choose a reason for hiding this comment

Uh oh!

rawwar Nov 1, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rawwar commented Nov 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner Nov 8, 2023

Choose a reason for hiding this comment

Uh oh!

vstinner Nov 8, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Nov 8, 2023

Choose a reason for hiding this comment

Uh oh!

vstinner commented Nov 8, 2023

Uh oh!

miss-islington-app Bot commented Nov 8, 2023

Uh oh!

bedevere-app Bot commented Nov 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gh-111495: Add tests for PyList C API#111562
vstinner merged 33 commits into
python:mainfrom
rawwar:kalyan/test-capi-list

rawwar commented Oct 31, 2023 •
edited by bedevere-app Bot
Loading

rawwar commented Nov 1, 2023 •
edited
Loading