| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
You add many env vars. Can you document them in Doc/using/cmdline.rst?
Usually, env var names start with PYTHON. Should the variables be renamed?
Also, Python ignores env var starting with PYTHON if sys.flags.ignore_environment.
Sorry, something went wrong.
| manually. | ||
|
|
||
| Note that there is also a built-in module _minimal_curses which will | ||
| hide this one if compiled in. |
There was a problem hiding this comment.
Is it part of this PR? If not, do you consider adding it or not?
Sorry, something went wrong.
There was a problem hiding this comment.
Yes, sounds like this comment was carried over from pypy but doesn't apply here.
Sorry, something went wrong.
|
@vstinner the PR is still draft, please wait until we mark it as finished before reviewing as most of this code may change |
Sorry, something went wrong.
…importing too much
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
There is already one (Misc/NEWS.d/next/Core and Builtins/2024-04-28-00-41-17.gh-issue-111201.cQsh5U.rst) |
Sorry, something went wrong.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
@hugovk @JelleZijlstra I have implemented your suggestions. If you have some time, do you mind reviewing again? |
Sorry, something went wrong.
There was a problem hiding this comment.
Docs changes look good.
One suggestion: this PR adds the main docs to the tutorial, we should probably add something to the reference, but this could be a followup.
Please also add a What's New entry.
There is already one (Misc/NEWS.d/next/Core and Builtins/2024-04-28-00-41-17.gh-issue-111201.cQsh5U.rst)
That's the changelog, this change definitely needs highlighting in https://docs.python.org/3.13/whatsnew/3.13.html but it can also be in a followup PR.
Sorry, something went wrong.
There was a problem hiding this comment.
Cool to see this!
Just to check, was it intentional that you didn't port PyPy's _pyrepl tests? There's not a huge amount of tests there, admittedly.
I am philosophically a little bit worried that people will start using and relying on _pyrepl internal details, which are now slightly different between PyPy and CPython, right? This could lead to PyPy's life getting somewhat harder in this area. As usual, it's hard to stop people from doing that, of course.
Sorry, something went wrong.
| self.restore() | ||
| yield | ||
| finally: | ||
| for arg in ("msg", "ps1", "ps2", "ps3", "ps4", "paste_mode"): |
There was a problem hiding this comment.
why is there a discrepancy between how prev_state is constructed (which uses fields(self) and how it is used in the finally block (listing the attributes explicitly)?
Sorry, something went wrong.
There was a problem hiding this comment.
It evolved into this, which you're right would now be cleaner to just reuse the list of fields.
I originally started with just dict(__dict__) but when I added typing with slots=True the __dict__ was gone so I modified it to use fields() instead.
Sorry, something went wrong.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 FreeBSD 3.x has failed when building commit f27f8c7. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/1223/builds/3012 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 643, in test_push_without_key_in_keymap
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 613, in test_empty
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 653, in test_push_with_keymap_in_keymap
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 668, in test_push_with_keymap_in_keymap_and_escape
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 633, in test_push_with_key_in_keymap
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 625, in test_insert
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 691, in test_push_unrecognized_escape_sequence
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 607, in test_get
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 682, in test_push_special_key
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 619, in test_flush_buf
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
|
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot ARM Raspbian 3.x has failed when building commit f27f8c7. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/424/builds/7064 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 691, in test_push_unrecognized_escape_sequence
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 625, in test_insert
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 613, in test_empty
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 653, in test_push_with_keymap_in_keymap
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 607, in test_get
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 682, in test_push_special_key
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 643, in test_push_without_key_in_keymap
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 668, in test_push_with_keymap_in_keymap_and_escape
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 633, in test_push_with_key_in_keymap
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 619, in test_flush_buf
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
|
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot aarch64 Debian Clang LTO + PGO 3.x has failed when building commit f27f8c7. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/1084/builds/4264 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 682, in test_push_special_key
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 613, in test_empty
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 625, in test_insert
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 691, in test_push_unrecognized_escape_sequence
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 668, in test_push_with_keymap_in_keymap_and_escape
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 619, in test_flush_buf
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 653, in test_push_with_keymap_in_keymap
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 643, in test_push_without_key_in_keymap
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 607, in test_get
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
Traceback (most recent call last):
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
return func(*newargs, **newkeywargs)
File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 633, in test_push_with_key_in_keymap
eq = EventQueue(sys.stdout.fileno(), "utf-8")
~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
|
Sorry, something went wrong.
Co-authored-by: Łukasz Langa <lukasz@langa.pl> Co-authored-by: Marta Gómez Macías <mgmacias@google.com> Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.