gh-111615: Fix regression in QueueHandler configuration. - #111638
Merged
vsajip merged 1 commit intoDec 27, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Author
|
Buildbot failures seem to be either Python build issues, or unrelated failures in test.test_asyncio.test_streams. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-113507 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 27, 2023
…nGH-111638) (cherry picked from commit 67655d8) Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
vsajip
pushed a commit
that referenced
this pull request
Dec 27, 2023
Copy link
Copy Markdown
Member
|
This broke the WASI builds as multiprocessing isn't available. Opened #113692 to track the breakage. https://buildbot.python.org/all/#/builders/1046/builds/3844 ======================================================================
ERROR: test_111615 (test.test_logging.ConfigDictTest.test_111615)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Lib/test/test_logging.py", line 3934, in test_111615
'queue': mp.get_context('spawn').Queue(),
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/Lib/multiprocessing/context.py", line 102, in Queue
from .queues import Queue
File "/Lib/multiprocessing/queues.py", line 23, in <module>
import _multiprocessing
ModuleNotFoundError: No module named '_multiprocessing'
----------------------------------------------------------------------
|
Sorry, something went wrong.
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.