FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-107265: Fix _PyFrame_OpAlreadyRan for ENTER_EXECUTOR case by corona10 · Pull Request #111645 · python/cpython · GitHub

/ cpython Public

gh-107265: Fix _PyFrame_OpAlreadyRan for ENTER_EXECUTOR case - #111645

Closed
corona10 wants to merge 3 commits into
python:mainfrom
corona10:gh-107265-_PyFrame_OpAlreadyRan
ConversationCommits (3)ChecksFiles changed
Closed

gh-107265: Fix _PyFrame_OpAlreadyRan for ENTER_EXECUTOR case#111645
corona10 wants to merge 3 commits into
python:mainfrom
corona10:gh-107265-_PyFrame_OpAlreadyRan

Conversation

corona10 commented Nov 2, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

corona10 requested a review from markshannon as a code owner November 2, 2023 13:48
bedevere-app Bot mentioned this pull request Nov 2, 2023
Closed
10 tasks

corona10 commented Nov 2, 2023

Copy link
Copy Markdown
Member Author

_PyFrame_OpAlreadyRan is only called for MAKE_CELL right now.
So it might be a low possibility that it will make an issue in the current situation.
But it should handle ENTER_EXECUTOR opcode case when comparing the opcode.

gvanrossum commented Nov 2, 2023

Copy link
Copy Markdown
Member

I will have to delay reviewing this, but my immediate reaction is that we want to make this function unnecessary, not more complicated.

corona10 commented Nov 2, 2023

Copy link
Copy Markdown
Member Author

I will have to delay reviewing this, but my immediate reaction is that we want to make this function unnecessary, not more complicated.

Yeah, I also agree that way too.

corona10 closed this Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently Awaiting requested review from ericsnowcurrently
gvanrossum Awaiting requested review from gvanrossum
markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL