gh-111354: Simplify _PyGen_yf by moving some of its work to the compiler and frame state - #111648
Merged
iritkatriel merged 2 commits intoNov 3, 2023
Merged
gh-111354: Simplify _PyGen_yf by moving some of its work to the compiler and frame state#111648iritkatriel merged 2 commits into
iritkatriel merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
iritkatriel
requested review from
brettcannon,
ericsnowcurrently,
markshannon,
ncoghlan and
warsaw
as code owners
November 2, 2023 14:53
markshannon
requested changes
Nov 2, 2023
markshannon
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I'd like to avoid the extra branch in YIELD_VALUE.
Other than that, looks good.
Sorry, something went wrong.
Copy link
Copy Markdown
|
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I have made the requested changes; please review again. |
Sorry, something went wrong.
markshannon
approved these changes
Nov 3, 2023
markshannon
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good.
Sorry, something went wrong.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
… compiler and frame state (python#111648)
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
… compiler and frame state (python#111648)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits the SUSPENDED frame state into SUSPENDED and SUSPENDED_YIELD_FROM, adds an oparg to YIELD_VALUE to indicate whether it's in a yield-from or await (so it can set the state correctly). With this, _PyGen_yf has a lot less work to do.
📚 Documentation preview 📚: https://cpython-previews--111648.org.readthedocs.build/