gh-111354: remove comparisons with enum values, variable reuse, unused imports in genobject.c - #111708
gh-111354: remove comparisons with enum values, variable reuse, unused imports in genobject.c#111708iritkatriel merged 9 commits into
Conversation
Sorry, something went wrong.
markshannon
left a comment
There was a problem hiding this comment.
A few comments
Sorry, something went wrong.
| /* Push arg onto the frame's value stack */ | ||
| result = arg ? arg : Py_None; | ||
| _PyFrame_StackPush(frame, Py_NewRef(result)); | ||
| PyObject *arg_obj = arg ? arg : Py_None; |
There was a problem hiding this comment.
Would it make sense to require arg to be not NULL? This is a static function, so we know all the callers.
(Not necessarily in this PR, though)
Sorry, something went wrong.
| } PyFrameState; | ||
|
|
||
| #define FRAME_STATE_SUSPENDED(S) ((S) == FRAME_SUSPENDED || (S) == FRAME_SUSPENDED_YIELD_FROM) | ||
| #define FRAME_STATE_CLOSED(S) ((S) >= FRAME_COMPLETED) |
There was a problem hiding this comment.
Does the state being FRAME_COMPLETED mean that it is closed?
Can't it be completed, but not closed?
Sorry, something went wrong.
There was a problem hiding this comment.
There is no CLOSED state. There is COMPLETED and CLEARED. CLOSED is a new category of both. Maybe FINISHED is a better name for this.
Sorry, something went wrong.
… unused imports in genobject.c (python#111708)
… unused imports in genobject.c (python#111708)
Tidies up genobject.c:
Reviewing individual commits might be easier.