FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-111765: move old PyFloat_* tests to Lib/test/test_capi/test_float.py by skirpichev · Pull Request #111766 · python/cpython · GitHub

/ cpython Public

gh-111765: move old PyFloat_* tests to Lib/test/test_capi/test_float.py - #111766

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
skirpichev:move-pack-unpack-tests-111765
Nov 7, 2023
ConversationCommits (2)ChecksFiles changed
Merged

gh-111765: move old PyFloat_* tests to Lib/test/test_capi/test_float.py #111766
serhiy-storchaka merged 2 commits into
python:mainfrom
skirpichev:move-pack-unpack-tests-111765

Conversation

skirpichev commented Nov 6, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Nov 6, 2023
Closed
bedevere-app Bot added the tests Tests in the Lib/test dir label Nov 6, 2023

skirpichev commented Nov 6, 2023

Copy link
Copy Markdown
Member Author

@AlexWaygood, probably this also can skip news?

skirpichev commented Nov 7, 2023

Copy link
Copy Markdown
Member Author

CC @serhiy-storchaka

serhiy-storchaka approved these changes Nov 7, 2023
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

I was going to suggest you make these changes, but it was obvious, so you already made them.

serhiy-storchaka merged commit a077b2f into python:main Nov 7, 2023
serhiy-storchaka added the needs backport to 3.12 only security fixes label Nov 7, 2023

miss-islington-app Bot commented Nov 7, 2023

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2023
pythongh-111765: Move old PyFloat_* tests to Lib/test/test_capi/test_…
fa4e7dd 
…float.py (pythonGH-111766)

(cherry picked from commit a077b2f)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>

bedevere-app Bot commented Nov 7, 2023

Copy link
Copy Markdown

GH-111818 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 7, 2023
skirpichev deleted the move-pack-unpack-tests-111765 branch November 7, 2023 11:51

skirpichev commented Nov 7, 2023

Copy link
Copy Markdown
Member Author

I was going to suggest you make these changes

That was actually suggested in #111624.

serhiy-storchaka pushed a commit that referenced this pull request Nov 7, 2023
[3.12] gh-111765: Move old PyFloat_* tests to Lib/test/test_capi/test…
f70ae99 
…_float.py (GH-111766) (GH-111818)

(cherry picked from commit a077b2f)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
hugovk pushed a commit to hugovk/cpython that referenced this pull request Nov 8, 2023
pythongh-111765: Move old PyFloat_* tests to Lib/test/test_capi/test_…
98b5117 
…float.py (pythonGH-111766)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-111765: Move old PyFloat_* tests to Lib/test/test_capi/test_…
ab8345f 
…float.py (pythonGH-111766)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-111765: Move old PyFloat_* tests to Lib/test/test_capi/test_…
8e7f0aa 
…float.py (pythonGH-111766)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL