GH-111485: Make BEFORE_WITH a uop - #111812
Merged
brandtbucher merged 1 commit intoNov 7, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
gvanrossum
approved these changes
Nov 7, 2023
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Yeah.
Sorry, something went wrong.
hugovk
pushed a commit
to hugovk/cpython
that referenced
this pull request
Nov 8, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #111540 (comment). I've tested that this works with uops enabled.
(Also, replace two calls to _PyObject_CallNoArgs with _PyObject_CallNoArgsTstate, since we have the tstate handy in the interpreter.)