FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-103791: handle `BaseExceptionGroup` in `contextlib.suppress()` by Zac-HD · Pull Request #111910 · python/cpython · GitHub

/ cpython Public

gh-103791: handle BaseExceptionGroup in contextlib.suppress() - #111910

Merged
iritkatriel merged 2 commits into
python:mainfrom
Zac-HD:zac-hd/suppress-baseexceptiongroup
Nov 10, 2023
ConversationCommits (2)ChecksFiles changed
Merged

gh-103791: handle BaseExceptionGroup in contextlib.suppress()#111910
iritkatriel merged 2 commits into
python:mainfrom
Zac-HD:zac-hd/suppress-baseexceptiongroup

Conversation

Zac-HD commented Nov 9, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Zac-HD requested a review from 1st1 as a code owner November 9, 2023 18:51
bedevere-app Bot mentioned this pull request Nov 9, 2023
Closed
Zac-HD mentioned this pull request Nov 9, 2023
Closed

gaogaotiantian commented Nov 9, 2023

Copy link
Copy Markdown
Member

I don't think we are going to backport this. This is not a bug in 3.12 - it's doing what the docs says. So I believe the changeversion could be just 3.13.

Zac-HD commented Nov 9, 2023

Copy link
Copy Markdown
Contributor Author

IMO it should be backported to 3.12.1: it seems likely that the missing support for BaseExceptionGroup was simply an oversight (@ambv might be able to confirm?), and it's much easier on users if we patch it promptly - the .0 versions aren't widely used.

iritkatriel reviewed Nov 9, 2023
View reviewed changes
Comment thread Doc/library/contextlib.rst
Comment thread Lib/test/test_contextlib.py

iritkatriel commented Nov 9, 2023

Copy link
Copy Markdown
Member

IMO it should be backported to 3.12.1: it seems likely that the missing support for BaseExceptionGroup was simply an oversight (@ambv might be able to confirm?), and it's much easier on users if we patch it promptly - the .0 versions aren't widely used.

I'd call it a bug and backport.

iritkatriel added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.12 only security fixes labels Nov 9, 2023
iritkatriel reviewed Nov 9, 2023
View reviewed changes
Comment thread Doc/library/contextlib.rst Outdated
Zac-HD force-pushed the zac-hd/suppress-baseexceptiongroup branch from 0dfe1a7 to bb4220c Compare November 10, 2023 04:40
Zac-HD force-pushed the zac-hd/suppress-baseexceptiongroup branch from bb4220c to b8bc136 Compare November 10, 2023 04:59
iritkatriel merged commit d61313b into python:main Nov 10, 2023

miss-islington-app Bot commented Nov 10, 2023

Copy link
Copy Markdown

Thanks @Zac-HD for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2023
pythongh-103791: handle BaseExceptionGroup in `contextlib.suppress(…
9e2096d 
…)` (pythonGH-111910)

(cherry picked from commit d61313b)

Co-authored-by: Zac Hatfield-Dodds <zac.hatfield.dodds@gmail.com>

bedevere-app Bot commented Nov 10, 2023

Copy link
Copy Markdown

GH-111955 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 10, 2023
iritkatriel pushed a commit that referenced this pull request Nov 10, 2023
[3.12] gh-103791: handle BaseExceptionGroup in `contextlib.suppress…
3780414 
…()` (GH-111910) (#111955)

gh-103791: handle `BaseExceptionGroup` in `contextlib.suppress()` (GH-111910)
(cherry picked from commit d61313b)

Co-authored-by: Zac Hatfield-Dodds <zac.hatfield.dodds@gmail.com>
Zac-HD deleted the zac-hd/suppress-baseexceptiongroup branch November 10, 2023 17:02
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-103791: handle BaseExceptionGroup in `contextlib.suppress(…
a2535e0 
…)` (python#111910)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-103791: handle BaseExceptionGroup in `contextlib.suppress(…
27cc8c8 
…)` (python#111910)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

iritkatriel iritkatriel approved these changes
1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL