gh-111856: fix os.fstat on windows with fat32 and exfat filesystem - #112038
Merged
zooba merged 1 commit intoNov 13, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 13, 2023
…tem (pythonGH-112038) (cherry picked from commit 29af736) Co-authored-by: AN Long <aisk@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-112044 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
zooba
pushed a commit
that referenced
this pull request
Nov 13, 2023
aisk
added a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change is just like #104892.
I think this is hard to test this on GHA, since it needs a disk with fat32 or exfat filesystem. I made a test on my local machine, the drive "E://" is a fat32 filesystem.
Test codes:
Before the comit:
C:\Users\xxxxx\Source\cpython>python a.py Running Debug|x64 interpreter... Traceback (most recent call last): File "C:\Users\xxxxx\Source\cpython\a.py", line 4, in <module> print(os.stat(f.fileno())) ^^^^^^^^^^^^^^^^^^^ OSError: [WinError 87] 参数错误。: 3 sys:1: ResourceWarning: unclosed file <_io.TextIOWrapper name='e://a.jpg' mode='r' encoding='cp936'>After the commit: