[3.12] gh-112088: Run autoreconf in GHA check_generated_files (GH-112090) - #112126
Closed
miss-islington wants to merge 1 commit into
Closed
[3.12] gh-112088: Run autoreconf in GHA check_generated_files (GH-112090)#112126miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…H-112090) The "Check if generated files are up to date" job of GitHub Actions now runs the "autoreconf -ivf -Werror" command instead of the "make regen-configure" command to avoid depending on the external quay.io server. Add Tools/build/regen-configure.sh script to regenerate the configure with an Ubuntu container image. The "quay.io/tiran/cpython_autoconf:271" container image (https://github.com/tiran/cpython_autoconf) is no longer used. (cherry picked from commit d9fd33a) Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington
requested review from
corona10,
erlend-aasland,
ezio-melotti and
hugovk
as code owners
November 15, 2023 20:47
This was referenced Nov 15, 2023
vstinner
enabled auto-merge (squash)
November 15, 2023 20:47
Copy link
Copy Markdown
Member
@hugovk Please check Sorry, wrong comment |
Sorry, something went wrong.
erlend-aasland
approved these changes
Nov 16, 2023
Copy link
Copy Markdown
Member
|
Does configure need regenerating locally and updating in this PR? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Yes, it needs to be regenerated; cc. @vstinner |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Check if generated files are up to date" job of GitHub Actions
now runs the "autoreconf -ivf -Werror" command instead of the "make
regen-configure" command to avoid depending on the external quay.io
server.
Add Tools/build/regen-configure.sh script to regenerate the configure
with an Ubuntu container image. The
"quay.io/tiran/cpython_autoconf:271" container image
(https://github.com/tiran/cpython_autoconf) is no longer used.
(cherry picked from commit d9fd33a)
Co-authored-by: Victor Stinner vstinner@python.org
📚 Documentation preview 📚: https://cpython-previews--112126.org.readthedocs.build/