| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Nice, thanks!
Sorry, something went wrong.
|
Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, something went wrong.
|
Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to 3.12 due to a conflict. cherry_picker 7680da458398c5a08b9c32785b1eeb7b7c0887e4 3.12 |
Sorry, something went wrong.
|
Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to 3.11 due to a conflict. cherry_picker 7680da458398c5a08b9c32785b1eeb7b7c0887e4 3.11 |
Sorry, something went wrong.
|
Will do manual backports later |
Sorry, something went wrong.
I just realised that there are no doctests in Lib/typing.py on the 3.12 or 3.11 branches, so there's no need :) I'll just remove the "needs backport" labels. |
Sorry, something went wrong.
We now do, of course, following the changes made for #112194, so if you're still up for backporting this to 3.12 and 3.11, that would be great :-) |
Sorry, something went wrong.
|
Sure! |
Sorry, something went wrong.
|
GH-112230 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
|
GH-112231 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
After this change we can detect some hypothetical problems with doctests in typing.py.
After my change to some incorrect value doctest fails:
» ./python.exe -m test test_typing Using random seed: 3171999375 0:00:00 load avg: 1.44 Run 1 test sequentially 0:00:00 load avg: 1.44 [1/1] test_typing test test_typing failed -- Traceback (most recent call last): File "/Users/sobolev/Desktop/cpython2/Lib/doctest.py", line 2267, in runTest raise self.failureException(self.format_failure(new.getvalue())) AssertionError: Failed doctest test for typing.get_protocol_members File "/Users/sobolev/Desktop/cpython2/Lib/typing.py", line 3398, in get_protocol_members ---------------------------------------------------------------------- File "/Users/sobolev/Desktop/cpython2/Lib/typing.py", line 3407, in typing.get_protocol_members Failed example: get_protocol_members(P) Expected: frozenset({'a', 'b', 'c'}) Got: frozenset({'a', 'b'}) test_typing failed (1 failure) == Tests result: FAILURE == 1 test failed: test_typing Total duration: 253 ms Total tests: run=601 failures=1 skipped=1 Total test files: run=1/1 failed=1 Result: FAILURE