FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-112186: Improve test case `test_loop_is_closed_resource_warnings` by dpr-0 · Pull Request #112187 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-112186: Improve test case test_loop_is_closed_resource_warnings - #112187

Merged
gvanrossum merged 3 commits into
python:mainfrom
dpr-0:Improve-test-case-test_loop_is_closed_resource_warnings
Nov 19, 2023
ConversationCommits (3)ChecksFiles changed
Merged

gh-112186: Improve test case test_loop_is_closed_resource_warnings#112187
gvanrossum merged 3 commits into
python:mainfrom
dpr-0:Improve-test-case-test_loop_is_closed_resource_warnings

Conversation

dpr-0 commented Nov 17, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Nov 17, 2023
bedevere-app Bot mentioned this pull request Nov 17, 2023
Closed
terryjreedy reviewed Nov 17, 2023
View reviewed changes

terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is a semantic change. The old code allows an exception; the replacement requires one and will fail if something is improved to avoid it. Do you really want this. If not, I would add a note that it would be OK to prevent the exception and remove the assert.

Minor nit: I think the comment fits better under the assert, after the object 'this' points to.

dpr-0 commented Nov 17, 2023

Copy link
Copy Markdown
Contributor Author

Do you really want this.

No. I just currently can not prevent RuntimeError while producing this test case scenario.

I would add a note that it would be OK to prevent the exception and remove the assert.

Thanks. It can be removed if there is no RuntimeError occur in the future.

gvanrossum approved these changes Nov 19, 2023
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LG, but I like to indent the comment.

Comment thread Lib/test/test_asyncio/test_streams.py Outdated
gvanrossum enabled auto-merge (squash) November 19, 2023 03:06
gvanrossum added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Nov 19, 2023
gvanrossum merged commit 18c6929 into python:main Nov 19, 2023

miss-islington-app Bot commented Nov 19, 2023

Copy link
Copy Markdown

Thanks @dpr-0 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington-app Bot commented Nov 19, 2023

Copy link
Copy Markdown

Sorry, @dpr-0 and @gvanrossum, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 18c692946953e586db432fd06c856531a2b05127 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2023
pythongh-112186: Improve test case `test_loop_is_closed_resource_warn…
ea69b4c 
…ings` (pythonGH-112187)

(cherry picked from commit 18c6929)

Co-authored-by: DPR <dpr-0xff@pm.me>

bedevere-app Bot commented Nov 19, 2023

Copy link
Copy Markdown

GH-112255 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 19, 2023
dpr-0 added a commit to dpr-0/cpython that referenced this pull request Nov 19, 2023
pythongh-112186: Improve test case `test_loop_is_closed_resource_warn…
5f3cbff 
…ings` (python#112187)

(cherry picked from commit 18c6929)

bedevere-app Bot commented Nov 19, 2023

Copy link
Copy Markdown

GH-112261 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Nov 19, 2023
dpr-0 deleted the Improve-test-case-test_loop_is_closed_resource_warnings branch November 19, 2023 09:20
gvanrossum pushed a commit that referenced this pull request Nov 19, 2023
[3.12] gh-112186: Improve test case `test_loop_is_closed_resource_war…
f521321 
…nings` (GH-112187) (#112255)

(cherry picked from commit 18c6929)

Co-authored-by: DPR <dpr-0xff@pm.me>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-112186: Improve test case `test_loop_is_closed_resource_warn…
1d85887 
…ings` (python#112187)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-112186: Improve test case `test_loop_is_closed_resource_warn…
36edc7f 
…ings` (python#112187)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

terryjreedy terryjreedy left review comments
gvanrossum gvanrossum approved these changes
kumaraditya303 kumaraditya303 approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
willingc Awaiting requested review from willingc willingc is a code owner

Assignees

gvanrossum

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL