FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-110383: Fix documentation profile cumtime fix by aptakhin · Pull Request #112221 · python/cpython · GitHub

/ cpython Public

gh-110383: Fix documentation profile cumtime fix - #112221

Merged
hugovk merged 3 commits into
python:mainfrom
aptakhin:gh-110383-profile-doc-cumtime-fix
Nov 19, 2023
ConversationCommits (3)ChecksFiles changed
Merged

gh-110383: Fix documentation profile cumtime fix#112221
hugovk merged 3 commits into
python:mainfrom
aptakhin:gh-110383-profile-doc-cumtime-fix

Conversation

aptakhin commented Nov 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

ghost commented Nov 17, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 17, 2023
bedevere-app Bot mentioned this pull request Nov 17, 2023
Closed
hugovk reviewed Nov 18, 2023
View reviewed changes
Comment thread Doc/library/profile.rst Outdated
1 0.000 0.000 0.000 0.000 _parser.py:435(_parse_sub)

The first line indicates that 214 calls were monitored. Of those calls, 207
The first line indicates that 214 calls were monitored. Of those calls, 207

hugovk Nov 18, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Let's not change unrelated whitespace.

Suggested change
The first line indicates that 214 calls were monitored. Of those calls, 207
The first line indicates that 214 calls were monitored. Of those calls, 207

aptakhin Nov 19, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sure, I also thought it was unrelated, just pretty close to context too. Returned

hugovk Nov 19, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks. I also prefer one space, but we allow either one or two: https://devguide.python.org/documentation/style-guide/#use-of-whitespace

Comment thread Doc/library/profile.rst Outdated
aptakhin and others added 2 commits November 19, 2023 09:14
Returned second space back
11fdc19
Reworded table reference
a9a85f5 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Nov 19, 2023
hugovk merged commit 6bf8f20 into python:main Nov 19, 2023

hugovk commented Nov 19, 2023

Copy link
Copy Markdown
Member

Thank you!

miss-islington-app Bot commented Nov 19, 2023

Copy link
Copy Markdown

Thanks @aptakhin for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2023
pythongh-110383: Fix documentation profile cumtime fix (pythonGH-112221)
f084add 
(cherry picked from commit 6bf8f20)

Co-authored-by: Alex Ptakhin <me@aptakhin.name>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2023
pythongh-110383: Fix documentation profile cumtime fix (pythonGH-112221)
12570c2 
(cherry picked from commit 6bf8f20)

Co-authored-by: Alex Ptakhin <me@aptakhin.name>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

bedevere-app Bot commented Nov 19, 2023

Copy link
Copy Markdown

GH-112262 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 19, 2023

bedevere-app Bot commented Nov 19, 2023

Copy link
Copy Markdown

GH-112263 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Nov 19, 2023

aptakhin commented Nov 19, 2023

Copy link
Copy Markdown
Contributor Author

Thank you for the help!

hugovk added a commit that referenced this pull request Nov 19, 2023
[3.11] gh-110383: Fix documentation profile cumtime fix (GH-112221) (#…
e9a97c3 
…112263)

Co-authored-by: Alex Ptakhin <me@aptakhin.name>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Nov 19, 2023
[3.12] gh-110383: Fix documentation profile cumtime fix (GH-112221) (#…
5134f66 
…112262)

Co-authored-by: Alex Ptakhin <me@aptakhin.name>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-110383: Fix documentation profile cumtime fix (python#112221)
4a482f2 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-110383: Fix documentation profile cumtime fix (python#112221)
7bf6987 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk left review comments

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL