Repository navigation
gh-112454: Disable TLS-PSK if OpenSSL was built without PSK support - #112491
Merged
gpshead merged 1 commit intoNov 29, 2023
Merged
gpshead merged 1 commit into
gpshead merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…port If OpenSSL was built without PSK support, the python TLS-PSK methods will raise "NotImplementedError" if called. Add a constant "ssl.HAS_PSK" to check if TLS-PSK is supported
Copy link
Copy Markdown
Contributor
Author
|
@ayappanec can you check if this fixes your issue? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Yes, it works with this fix. |
Sorry, something went wrong.
gpshead
approved these changes
Nov 29, 2023
Copy link
Copy Markdown
Member
|
Thanks for the pre-release testing ayappanec! |
Sorry, something went wrong.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…port (python#112491) If OpenSSL was built without PSK support, the python TLS-PSK methods will raise "NotImplementedError" if called. Add a constant "ssl.HAS_PSK" to check if TLS-PSK is supported
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…port (python#112491) If OpenSSL was built without PSK support, the python TLS-PSK methods will raise "NotImplementedError" if called. Add a constant "ssl.HAS_PSK" to check if TLS-PSK is supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a side note (a mistake I made when trying to test this), make sure to build OpenSSL with:
and not:
otherwise OPENSSL_NO_PSK is not available in the OpenSSL public headers.
CC: @gpshead
📚 Documentation preview 📚: https://cpython-previews--112491.org.readthedocs.build/