FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-107784 Document interpid C-API and new Unstable API for fetching `__main__` of interpreter by tonybaloney · Pull Request #112548 · python/cpython · GitHub

/ cpython Public

gh-107784 Document interpid C-API and new Unstable API for fetching __main__ of interpreter - #112548

Closed
tonybaloney wants to merge 5 commits into
python:mainfrom
tonybaloney:document_interpid
ConversationCommits (5)ChecksFiles changed
Closed

gh-107784 Document interpid C-API and new Unstable API for fetching __main__ of interpreter#112548
tonybaloney wants to merge 5 commits into
python:mainfrom
tonybaloney:document_interpid

Conversation

tonybaloney commented Nov 30, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Nov 30, 2023
Open
bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 30, 2023

tonybaloney commented Nov 30, 2023

Copy link
Copy Markdown
Contributor Author

Can be back-ported to Python 3.12

tonybaloney commented Nov 30, 2023

Copy link
Copy Markdown
Contributor Author

@ericsnowcurrently interpid type is opaque, is that correct?

blaisep suggested changes May 20, 2024
View reviewed changes

blaisep left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please change

A interpreter ID identifies a interpreter and may be used as an int.

to

A interpreter ID identifies a interpreter and may be used as an :class:`int`.

Comment thread Doc/c-api/init.rst
:c:func:`Py_FinalizeEx` will destroy all sub-interpreters that
haven't been explicitly destroyed at that point.

Interpreter ID Objects

blaisep May 20, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm giving this some attention so that we can get it merged soon.
This section looks good so far

Comment thread Doc/c-api/init.rst
Interpreter ID Objects
----------------------

A interpreter ID identifies a interpreter and may be used as an int.

blaisep May 20, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@hugovk suggested that you link to the class definition,
changing

A interpreter ID identifies a interpreter and may be used as an int.

to

A interpreter ID identifies a interpreter and may be used as an :class:`int`.

blaisep May 20, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
A interpreter ID identifies a interpreter and may be used as an int.
A interpreter ID identifies a interpreter and may be used as an :class:`int`.

blaisep suggested changes May 20, 2024
View reviewed changes

blaisep left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

(added the change as a markdown suggestion to make it more convenient)

Comment thread Doc/c-api/init.rst
Interpreter ID Objects
----------------------

A interpreter ID identifies a interpreter and may be used as an int.

blaisep May 20, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
A interpreter ID identifies a interpreter and may be used as an int.
A interpreter ID identifies a interpreter and may be used as an :class:`int`.

ericsnowcurrently commented May 21, 2024

Copy link
Copy Markdown
Member

FYI, I've dropped interpreter ID objects.

blaisep commented May 21, 2024

Copy link
Copy Markdown
Contributor

FYI, I've dropped interpreter ID objects.
Are you recommending that we close this PR? (Is is obsolete?)

ericsnowcurrently commented May 21, 2024

Copy link
Copy Markdown
Member

I'd need to double-check, but, yeah, we'd probably close this PR.

blaisep commented May 21, 2024

Copy link
Copy Markdown
Contributor

I'd need to double-check, but, yeah, we'd probably close this PR.

Thank you @ericsnowcurrently , I will ask @tonybaloney if he will close this PR.

willingc commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

@tonybaloney I'm going to close this PR. If needed we can reopen. Thanks.

willingc closed this Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
blaisep blaisep requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review docs Documentation in the Doc dir skip news topic-subinterpreters

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL