FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-95754: Better AttributeError on partially initialised module by hauntsaninja · Pull Request #112577 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-95754: Better AttributeError on partially initialised module - #112577

Merged
hauntsaninja merged 7 commits into
python:mainfrom
hauntsaninja:gh95754
Dec 21, 2023
ConversationCommits (7)ChecksFiles changed
Merged

gh-95754: Better AttributeError on partially initialised module#112577
hauntsaninja merged 7 commits into
python:mainfrom
hauntsaninja:gh95754

Conversation

hauntsaninja commented Dec 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Dec 1, 2023
Closed
serhiy-storchaka reviewed Dec 1, 2023
View reviewed changes
Comment thread Objects/moduleobject.c Outdated
if (suppress != 1) {
if (_PyModuleSpec_IsInitializing(spec)) {
PyErr_Format(PyExc_AttributeError,
origin = PyObject_GetAttr(spec, &_Py_ID(origin));

serhiy-storchaka Dec 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

PyObject_GetAttr() can set not only AttributeError. If it sets a different error, it should not be overridden by AttributeError.

I suggest to use PyObject_GetOptionalAttr().

iritkatriel Dec 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why not chain the original error to a new exception (raise from)?

iritkatriel Dec 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Or maybe this is a use case for adding a note to the original exception and letting it propagate on (if we don't want to change the type of the exception being raised).

Comment thread Objects/moduleobject.c Outdated
serhiy-storchaka reviewed Dec 3, 2023
View reviewed changes
Comment thread Objects/moduleobject.c

hauntsaninja commented Dec 4, 2023

Copy link
Copy Markdown
Contributor Author

Thank you for the reviews!

serhiy-storchaka commented Dec 7, 2023

Copy link
Copy Markdown
Member

I fixed some errors, please resolve conflicts.

serhiy-storchaka reviewed Dec 18, 2023
View reviewed changes
Comment thread Objects/moduleobject.c Outdated
serhiy-storchaka approved these changes Dec 18, 2023
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

hauntsaninja merged commit 61e8184 into python:main Dec 21, 2023
hauntsaninja deleted the gh95754 branch December 21, 2023 21:24

hugovk commented Dec 21, 2023

Copy link
Copy Markdown
Member

Would be great to mention this nice quality-of-life improvement with an example in What's New, similar to:

https://docs.python.org/3/whatsnew/3.12.html#improved-error-messages

ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
pythongh-95754: Better AttributeError on partially initialised module (…
7eadfa9 
…python#112577)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
hauntsaninja mentioned this pull request Jan 6, 2024
Merged
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
pythongh-95754: Better AttributeError on partially initialised module (…
17f31d6 
…python#112577)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-95754: Better AttributeError on partially initialised module (…
4bb2407 
…python#112577)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-95754: Better AttributeError on partially initialised module (…
c698237 
…python#112577)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
hugovk mentioned this pull request Jun 29, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

iritkatriel iritkatriel left review comments
serhiy-storchaka serhiy-storchaka approved these changes
brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL