FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-99180: Remove traceback anchors in return and assign statements that cover all the displayed range by pablogsal · Pull Request #112670 · python/cpython · GitHub

/ cpython Public

gh-99180: Remove traceback anchors in return and assign statements that cover all the displayed range - #112670

Merged
pablogsal merged 1 commit into
python:mainfrom
pablogsal:gh-99180
May 1, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-99180: Remove traceback anchors in return and assign statements that cover all the displayed range#112670
pablogsal merged 1 commit into
python:mainfrom
pablogsal:gh-99180

Conversation

pablogsal commented Dec 3, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Dec 3, 2023
Closed
pablogsal force-pushed the gh-99180 branch 3 times, most recently from bb342a0 to 6e941e1 Compare December 3, 2023 18:22
AlexWaygood reviewed Dec 3, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Spotted some minor typos:

Comment thread Lib/test/test_traceback.py Outdated
Comment thread Lib/test/test_traceback.py Outdated
pablogsal requested a review from lysnikolaou January 8, 2024 15:12

pablogsal commented Jan 8, 2024

Copy link
Copy Markdown
Member Author

Hey @lysnikolaou, can you check if this is more or less what you had in mind? (I will rebase soon)

pythongh-99180: Remove traceback anchors in return and assign stateme…
343a058 
…nts that cover all the displayed range

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>

Apply suggestions from code review

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

fix whitespace issue causing the lint check to fail
lysnikolaou approved these changes Jan 9, 2024
View reviewed changes

lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks a lot like what I had in mind and seeing the implementation I think it's a step towards the right direction!

lysnikolaou commented Feb 26, 2024

Copy link
Copy Markdown
Member

@pablogsal Let's merge this?

pablogsal merged commit 4a08a75 into python:main May 1, 2024
pablogsal deleted the gh-99180 branch May 1, 2024 13:42
pablogsal added the needs backport to 3.12 only security fixes label May 1, 2024
pablogsal removed the needs backport to 3.12 only security fixes label May 1, 2024
python deleted a comment from miss-islington-app Bot May 1, 2024
python deleted a comment from miss-islington-app Bot May 1, 2024

bedevere-bot commented May 1, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.x has failed when building commit 4a08a75.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1380/builds/143) and take a look at the build logs.
  4. Check if the failure is related to this commit (4a08a75) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1380/builds/143

Failed tests:

  • test_socket

Failed subtests:

  • test_dual_stack_client_v6 - test.test_socket.CreateServerFunctionalTest.test_dual_stack_client_v6

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/358FF9CB-4D5D-4034-8AFB-6FDD92A7A50B/data/Containers/Bundle/Application/1CB439A9-DD6A-4243-BF2F-EC7DA3A99532/iOSTestbed.app/python/lib/python3.13/test/test_socket.py", line 6847, in test_dual_stack_client_v6
    with socket.create_server(("", port), family=socket.AF_INET6,
         ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                              dualstack_ipv6=True) as sock:
                              ^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/358FF9CB-4D5D-4034-8AFB-6FDD92A7A50B/data/Containers/Bundle/Application/1CB439A9-DD6A-4243-BF2F-EC7DA3A99532/iOSTestbed.app/python/lib/python3.13/socket.py", line 934, in create_server
    raise error(err.errno, msg) from None
OSError: [Errno 48] Address already in use (while attempting to bind on address ('', 57463))

SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
pythongh-99180: Remove traceback anchors in return and assign stateme…
5460446 
…nts that cover all the displayed range (python#112670)
AlexWaygood reviewed May 24, 2024
View reviewed changes
Comment thread Lib/traceback.py

return ''.join(row)

def should_show_carets(self, start_offset, end_offset, all_lines, anchors):

AlexWaygood May 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is this method meant to be a public-API method on StackSummary objects, or is it meant to be private API? If the former, we should probably document it at https://docs.python.org/3.13/library/traceback.html#stacksummary-objects. If the latter, maybe it should have a name prefixed with an underscore?

pablogsal May 24, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It should be private so I am fine prefixing it with an underscore

AlexWaygood May 25, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

#119554

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood left review comments
lysnikolaou lysnikolaou approved these changes
iritkatriel Awaiting requested review from iritkatriel

Assignees

pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL