[3.12] gh-108927: Fix removing testing modules from sys.modules (GH-108952) - #112711
Merged
serhiy-storchaka merged 1 commit intoDec 4, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…nGH-108952) It breaks import machinery if the test module has submodules used in other tests. (cherry picked from commit e08b70f) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
December 4, 2023 15:43
serhiy-storchaka
enabled auto-merge (squash)
December 4, 2023 16:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It breaks import machinery if the test module has submodules used in
other tests.
(cherry picked from commit e08b70f)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com